977097 - Add more aliases for the UTC timezone

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: utcaliases.diff

I've run into the situation where other clients will send an event with TZID=Etc/GMT without defining the timezone. To work around this I think we can add a few more aliases (taken from wikipedia) for UTC.

I will need this for 2.6.5, given I am just adding functionality and not changing it I think the risk is low enough.

Comment 1

[Mohit Kanwal [:redDragon]]

Comment on attachment 8382218 [details] [diff] [review]
utcaliases.diff

Review of attachment 8382218 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/base/src/calTimezoneService.js
@@ +102,5 @@
> +                                "Etc/UCT", "Etc/Unversal", "Etc/UTC",
> +                                "Etc/Zulu", "GMT", "GMT+0", "GMT0",
> +                                "Greenwich", "UCT", "Universal", "Zulu"];
> +
> +            for (let zone of utcAliases) {

shouldn't this be let zone in utcAliases?

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8382218 [details] [diff] [review]
utcaliases.diff

Its new and shiny :)

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of

the old method was for each (let zone in utcAliases), the new one is for (let zone of utcAliases).

Comment 3

[Mohit Kanwal [:redDragon]]

Comment on attachment 8382218 [details] [diff] [review]
utcaliases.diff

Review of attachment 8382218 [details] [diff] [review]:
-----------------------------------------------------------------

Ah! I missed that. Looks pretty shiny :) although to me for each..in still makes readable sense :)

::: calendar/base/src/calTimezoneService.js
@@ +102,5 @@
> +                                "Etc/UCT", "Etc/Unversal", "Etc/UTC",
> +                                "Etc/Zulu", "GMT", "GMT+0", "GMT0",
> +                                "Greenwich", "UCT", "Universal", "Zulu"];
> +
> +            for (let zone of utcAliases) {

Ha Ha! Learnt something new! Nice!

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 75415ebea93e

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to releases/comm-aurora changeset 24ae86940cfe

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to releases/comm-beta changeset 1643851618ef

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to releases/comm-esr24 changeset 23aabf445f76