977124 - add client-side validation for email field

Status: RESOLVED FIXED

(Input Graveyard :: Submission, defect, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

I just pushed out a new feedback form which ignores the django validation for fields. We do client-side validation of description field, but we're not doing client-side validation of the email field.

I thought we were, though, so I'm puzzled.

This bug covers adding client-side validation of the email field.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P1 for this quarter. Fixing this will improve submitted data.

What needs to happen is that we need to add some code to validate the email field as the user is typing and do a red border if it's not a valid email address where "valid" is going to be determined by a regex of some kind. It should be a really loose regex like \w+@\w+.\w+ or something along those lines.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Joshua and I discussed this on IRC. The gist of it is this:

1. add client-side validation in JS to match the validation that Django does -- no error messages, just make the box red; there should be a style for that already

2. keep the server-side validation that Django does because this reduces script-kiddie-related problems

I originally said we shouldn't use the HTML5 email field type, but I'm changing my mind on that. So this is a third thing to do here:

3. use the HTML5 email field type (i.e. <input type="email">)

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Moving this to 2014q2.

Comment 4

[Joshua Smith [:joshua-s]]

I will try to work on it this week.

Comment 5

[Joshua Smith [:joshua-s]]

This depends on the function I created in Bug 977122.

Comment 6

[Joshua Smith [:joshua-s]]

Attachment: PR on GitHub

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/252

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/fjord/commit/52e815a

I'll push that out on Monday.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pushed to prod last night.