977146 - [Bluetooth] Push ToggleBtAck into backends

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

We need to push ToggleBtAck into the backends in order to send it at the end of the BlueZ start/stop code.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 977146: Set PROP_BLUETOOTH_ENABLED in ToggleBtAck

This is patch [02] from 957103.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 977146: Declare ToggleBtAck in header file

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 977146: Push ToggleBtAck into implementations of {Start|Stop}Internal

I tested this patch on the Unagi and the Nexus 4, to make sure that both, BlueZ and Bluedroid, work with the change.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8382284 [details] [diff] [review]
[03] Bug 977146: Push ToggleBtAck into implementations of {Start|Stop}Internal

Review of attachment 8382284 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and agree with you that we really need cleanups for BluetoothDBusService.cpp. Thanks, ready for the next patch. :)

Comment 5

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8382284 [details] [diff] [review]
[03] Bug 977146: Push ToggleBtAck into implementations of {Start|Stop}Internal

Review of attachment 8382284 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and agree with you that we really need cleanups for BluetoothDBusService.cpp. Thanks, ready for the next patch. :)

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks for the review. :)

https://hg.mozilla.org/integration/b2g-inbound/rev/c9b9f084254f
https://hg.mozilla.org/integration/b2g-inbound/rev/370929a8581b
https://hg.mozilla.org/integration/b2g-inbound/rev/518861876498

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=518861876498

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c9b9f084254f
https://hg.mozilla.org/mozilla-central/rev/370929a8581b
https://hg.mozilla.org/mozilla-central/rev/518861876498