977173 - Content interactions navigate user away from viewed page

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Aaron Train [:aaronmt]]

STR

i) Open a private tab, visit http://mail.google.com
ii) In the same tab, visit http://facebook.com and log in
iii) Tap the menu, and notification buttons

See

A Cross-Origin Request Blocked warning in console. The user is then redirected back to Gmail or whatever is viewed before Facebook.

Don't know if the warning is related to the problem here. Please re-summarize if so.

Comment 1

[Aaron Train [:aaronmt]]

On tap of Facebook's globe icon e.g, I am booted back to Gmail.

Comment 2

[Aaron Train [:aaronmt]]

Happens in regular tabs too. I noticed I had to hit the menu, and notifications, and messages icons a few times. Each time Facebook did a 'reload' and eventually I was redirected back to content viewed before accessing Facebook.

Comment 3

[Brian Nicholson (:bnicholson)]

I'm able to reproduce this bug even in release.

Comment 4

[Brian Nicholson (:bnicholson)]

Bleh, sorry for bugspam. I guess we don't want to track specific firefox releases if this isn't a regression, do we?

Comment 5

[Aaron Train [:aaronmt]]

Confirming I see this on release too, took a little more effort though.

Comment 6

[Aaron Train [:aaronmt]]

This seems to happen frequently in interacting with the menu and social toolbar in Facebook in 28.0b6 thus making Facebook (in conjunction with bug 977226) painful to use on beta 28.0

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Apparently this go significantly worse on 28, need to investigate

Comment 8

[Brian Nicholson (:bnicholson)]

With bug 977226 fixed, the behavior on 28/29/30 is now the same as release. It's reproducible, but not as easy to hit. STR are mostly the same as comment 0, but for step iii, repeatedly (and quickly) hit the facebook chat icon.

Renoming since we're back to release state.

Comment 10

[Aaron Train [:aaronmt]]

Analyzing builds from last April and I am still able to reproduce. Been broken for a long time if not always. With more recent builds, e.g, using Nightly (03/02), today's build, it is far more easier to reproduce. Earlier builds require more effort.

Comment 11

[Lucas Rocha (:lucasr)]

Mike, this might be a Facebook-specific issue. Could you have a look?

Comment 12

[Benoit]

The Facebook issue I described in bug #978536 doesn't happen anymore with the last beta from the Google Play store (I'm able to open the Facebook toaster, messages and globe menus again).

So it may have been a different bug, but it seems it has been fixed anyway.

Comment 13

[Aaron Train [:aaronmt]]

The previous candidate had a patch which made it easier to reproduce.

Comment 14

[Mike Taylor [:miketaylr]]

On PTO until next Thursday, so cc'ing Hallvord to see if he can get to this quicker.

Comment 15

[Mike Taylor [:miketaylr]]

Hallvord, can you take a look?

Comment 16

[Hallvord R. M. Steen [:hallvors]]

There's some stuff going on here:
https://fbstatic-a.akamaihd.net/rsrc.php/v2/yt/r/qtvra8B3kkS.js

        popSoftState: function (p) {
            if (!o._enabled) return ;
            if (o._softState === p) n(function () {
                if (o._softState === p) history.go( - 1);
            }, 0);
        },
<X>
        pushState: function (p) {
            if (!o._enabled) return ;
            if (o._softState) {
                return o.replaceState(p);
            } else {
                o._updateSoftState(p);
                o._updateXRefererCookie(p);
                return i.push(new k(p) .normalize() .toString());
            }
        },

I think what happens is that the script is written to "pop" the current state and, when the new "state" loads, "push" it. Now, "popping" the state involves actual history navigation (history.go(-1)) - meaning that if you push a button again before the new feature/state loads and is push()ed, you'll end up calling history.go(-1) twice without an intermediate navigation - the first go(-1) will undo the #hash navigation that's part of Facebook's history mechanism while the second (because no new #hash was added meanwhile) will take you right back to the previous site.

(This is still a bit of guesswork - I'll do some logging and see if I can verify it)

Comment 17

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]

Comment 18

[:Margaret Leibovic]

I assume Facebook has changed since this bug was filed... is this still an issue?

Comment 19

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.