977199 - [a11y] Add aria-label to markup-view.xul

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Rob Campbell [:rc] (:robcee)]

selecting markup view in inspector doesn't return a useful name on focus. Currently returns markup-view.xul, should return something like Inspector panel, markup view.

Settable via aria-label attribute, may want to set an aria-role attribute on the view as well.

Comment 1

[Marco Zehe (:MarcoZ)]

Also something immediately heard by screen reader users when opening the panel. Listening to URLs is a bad user experience, and it is difficult to discern what this thing is, therefore it gets a p1.

Comment 2

[Athena]

I'm interested in this.

Comment 3

[Marco Zehe (:MarcoZ)]

Sure, go right ahead! :) Unless you already see a patch on a bug you're interested in, just grabbing it and providing a patch is fine. :)

Comment 4

[Athena]

Attachment: Add aria-label "Markup View"

Sure. I can't assign bugs to myself right now, but I think I've figured out how to ask for it, and I'll keep that in mind for next time.

Note: This patch unfortunately depends on the attachment to bug 977169 because it touches lines too close in the same file, so I'll wait for that to be resolved one way or another before requesting review here.

Comment 5

[Marco Zehe (:MarcoZ)]

Athena, feel free to request review on this patch. I am going to checkin the one for bug 977169 soon.

Comment 6

[Athena]

Comment on attachment 8450080 [details] [diff] [review]
Add aria-label "Markup View"

Thanks for the heads-up/checkin, Marco.

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8450080 [details] [diff] [review]
Add aria-label "Markup View"

Review of attachment 8450080 [details] [diff] [review]:
-----------------------------------------------------------------

Please rebase this and add a commit message

Comment 8

[Athena]

Attachment: Add aria-label "Markup View"

Comment 9

[Brian Grinstead [:bgrins]]

Comment on attachment 8452085 [details] [diff] [review]
Add aria-label "Markup View"

Review of attachment 8452085 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me - pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=2a87b94a52b4

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/660b0370c394

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/660b0370c394