Closed Bug 977199 Opened 10 years ago Closed 10 years ago

[a11y] Add aria-label to markup-view.xul

Categories

(DevTools :: Inspector, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: rcampbell, Assigned: athena)

References

Details

Attachments

(1 file, 1 obsolete file)

selecting markup view in inspector doesn't return a useful name on focus. Currently returns markup-view.xul, should return something like Inspector panel, markup view.

Settable via aria-label attribute, may want to set an aria-role attribute on the view as well.
Also something immediately heard by screen reader users when opening the panel. Listening to URLs is a bad user experience, and it is difficult to discern what this thing is, therefore it gets a p1.
Priority: -- → P1
I'm interested in this.
Sure, go right ahead! :) Unless you already see a patch on a bug you're interested in, just grabbing it and providing a patch is fine. :)
Attached patch Add aria-label "Markup View" (obsolete) — Splinter Review
Sure. I can't assign bugs to myself right now, but I think I've figured out how to ask for it, and I'll keep that in mind for next time.

Note: This patch unfortunately depends on the attachment to bug 977169 because it touches lines too close in the same file, so I'll wait for that to be resolved one way or another before requesting review here.
Attachment #8450080 - Flags: feedback?(marco.zehe)
Attachment #8450080 - Flags: feedback?(marco.zehe) → feedback+
Assignee: nobody → athena
Status: NEW → ASSIGNED
Athena, feel free to request review on this patch. I am going to checkin the one for bug 977169 soon.
Comment on attachment 8450080 [details] [diff] [review]
Add aria-label "Markup View"

Thanks for the heads-up/checkin, Marco.
Attachment #8450080 - Flags: review?(bgrinstead)
Comment on attachment 8450080 [details] [diff] [review]
Add aria-label "Markup View"

Review of attachment 8450080 [details] [diff] [review]:
-----------------------------------------------------------------

Please rebase this and add a commit message
Attachment #8450080 - Flags: review?(bgrinstead)
Attachment #8450080 - Attachment is obsolete: true
Attachment #8452085 - Flags: review?(bgrinstead)
Comment on attachment 8452085 [details] [diff] [review]
Add aria-label "Markup View"

Review of attachment 8452085 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me - pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=2a87b94a52b4
Attachment #8452085 - Flags: review?(bgrinstead) → review+
Attachment #8452085 - Flags: checkin?
Attachment #8452085 - Flags: checkin?
https://hg.mozilla.org/mozilla-central/rev/660b0370c394
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
See Also: → 1158550
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.