977260 - nsDOMCameraControl does not inherit directly from nsWrapperCache, so it should not implement the wrapper cache CC gunk

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Andrew McCreight [:mccr8]]

I'm not sure if this is somehow causing bug 975876, but it can't be good.

Comment 1

[Andrew McCreight [:mccr8]]

I can't see how this could possibly cause any problems, but let's see if it helps.
  https://tbpl.mozilla.org/?tree=Try&rev=d93998b5edba

Comment 2

[Andrew McCreight [:mccr8]]

As I expected, we still hit the crash with my patch for this.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Don't implement wrappercache CC stuff for nsDOMCameraControl.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Use more macros for CC nsDOMCameraControl stuff.

Use more powerful macros for nsDOMCameraControl

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8383172 [details] [diff] [review]
part 2 - Use more macros for CC nsDOMCameraControl stuff.

(I wonder if we could implement those macros using some template magic.)

Comment 6

[Andrew McCreight [:mccr8]]

Yeah, I think there is something like variable argument templates, but I'm not sure it is supported in VS2010 or not.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/c9bb7edc607d
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e637f7b15f5c

Comment 7

[(no longer active)]

(In reply to comment #6)
> Yeah, I think there is something like variable argument templates, but I'm not
> sure it is supported in VS2010 or not.

It's not, they added support in VS2012 I think.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c9bb7edc607d
https://hg.mozilla.org/mozilla-central/rev/e637f7b15f5c