Closed Bug 977260 Opened 6 years ago Closed 6 years ago

nsDOMCameraControl does not inherit directly from nsWrapperCache, so it should not implement the wrapper cache CC gunk

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(2 files)

I'm not sure if this is somehow causing bug 975876, but it can't be good.
I can't see how this could possibly cause any problems, but let's see if it helps.
  https://tbpl.mozilla.org/?tree=Try&rev=d93998b5edba
As I expected, we still hit the crash with my patch for this.
No longer blocks: 975876
Use more powerful macros for nsDOMCameraControl
Attachment #8383172 - Flags: review?(bugs)
Attachment #8383171 - Flags: review?(bugs) → review+
Comment on attachment 8383172 [details] [diff] [review]
part 2 - Use more macros for CC nsDOMCameraControl stuff.

(I wonder if we could implement those macros using some template magic.)
Attachment #8383172 - Flags: review?(bugs) → review+
Yeah, I think there is something like variable argument templates, but I'm not sure it is supported in VS2010 or not.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/c9bb7edc607d
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e637f7b15f5c
(In reply to comment #6)
> Yeah, I think there is something like variable argument templates, but I'm not
> sure it is supported in VS2010 or not.

It's not, they added support in VS2012 I think.
https://hg.mozilla.org/mozilla-central/rev/c9bb7edc607d
https://hg.mozilla.org/mozilla-central/rev/e637f7b15f5c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.