Closed Bug 977275 Opened 7 years ago Closed 7 years ago
Add a horrible install-to-subdir hack in test manifests to support a goofy set of tests
The tests in bug 948801 (toolkit/mozapps/extensions/test/browser) currently install themselves to two different directories in order to run the same set of tests with variant behavior. This is a big PITA, but I'd like to get them into a manifest, so I invented this horrible manifest hack to support this for now. You can set: [DEFAULT] install-to-subdir = foo and the tests will get installed to $relativesrcdir/foo/ instead of just $relativesrcdir. Once we switch things over to actually running the tests from a manifest we can fix this in a better way (by adding a key to this manifest instead, and exposing it to the tests). I will, in fact, file a bug to fix this the right way after I file this one.
Comment on attachment 8382466 [details] [diff] [review] Add a horrible install-to-subdir hack in test manifests to support a goofy set of tests Review of attachment 8382466 [details] [diff] [review]: ----------------------------------------------------------------- ::: python/mozbuild/mozbuild/frontend/emitter.py @@ +470,5 @@ > filtered = m.active_tests(disabled=False, **self.mozinfo) > > out_dir = mozpath.join(install_prefix, manifest_reldir) > + if 'install-to-subdir' in defaults: > + # This is terrible, but what are you going to do? Please throw the unhack bug # in here. ::: python/mozbuild/mozbuild/test/frontend/test_emitter.py @@ +346,5 @@ > paths = sorted([v for v in o.installs.values()]) > self.assertEqual(paths, expected) > > + def test_test_manifest_install_to_subdir(self): > + """ """ This empty comment is terrible, but what are you going to do?
Attachment #8382466 - Flags: review?(gps) → review+
I forgot to address those review comments because I'm a bad person. I apologize. I did file the followup: bug 977541. https://hg.mozilla.org/integration/mozilla-inbound/rev/0b504e05ccc3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.