977278 - [B2G][Camera] Picture thumbnails can be partially seen when rotating the Camera from portrait to landscape mode, even though the thumbnail bar has been dismissed.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[J Zimbrick]

Description:
When the user rotates the Camera app from portrait to landscape mode, parts of the picture thumbnails can be seen rotating at the top of the screen, even when the thumbnail bar has been dismissed.

Repro Steps:
1. Update Buri device to build: 20140226004002.
2. Open the Camera app.
3. Take a picture, the thumbnail bar should drop down from the top showing a thumbnail of the picture you just took.
4. Tap the center of the screen to dismiss the thumbnail bar. 
5. Rotate the camera from portrait mode to landscape mode, keeping on an eye on the top left corner.
6. Observe that the part of the picture thumbnail can be seen rotating, even though the thumbnail bar has been dismissed.

Actual:
Parts of picture thumbnails can be seen when rotating the Camera from portrait to landscape mode, even when the thumbnail bar has been dismissed.

Expected:
No parts of the picture thumbnails can be seen in the Camera at any time when the thumbnail bar is not visible.

Environmental Variables:
Device: Buri
BuildID: 20140226004002
Gaia: da50b2b62ed96993cf4df22e3d69c435b28506bd
Gecko: 3c39d1e487d9
Version: 28.0
Firmware Version: V1.2-device.cfg

Notes:

Repro frequency: 100%

This issue is especially noticeable if you take more pictures, all can be seen rotating at the top of the screen.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request #16677

Comment 2

[David Flanagan [:djf]]

Comment on attachment 8382515 [details] [review]
GitHub Pull Request #16677

I love one-line reviews!

This looks good to me. I'm assuming you've tested.

This is a very low-risk patch because we intend to remove the filmstrip anyway.

Go ahead and land to master.

Comment 3

[Jason Smith [:jsmith]]

Clearing regression flag - I don't see analysis here proving this is a regression. I also am having trouble reproducing this.

Comment 4

[Justin D'Arcangelo [:justindarc]]

jsmith: You're right that it probably wasn't a regression since it looks like the affected CSS has been in the codebase for quite some time, but I could definitely reproduce it. There is a transition animation on the thumbnails for 200ms which is the timeframe for which you can see the thumbnails rotating. It happens very quickly so it may not be noticeable 100% of the time.

Comment 5

[Justin D'Arcangelo [:justindarc]]

https://github.com/mozilla-b2g/gaia/commit/6687813659de3f7edfedcf19f77f40ce774aacb4