Closed Bug 977279 Opened 10 years ago Closed 10 years ago

Unresolved symbol (_IID_D2D1DeviceContext) in DrawTargetD2D.obj

Categories

(Firefox Build System :: General, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: marco, Assigned: ehsan.akhgari)

References

Details

(Keywords: regression)

Attachments

(3 files)

I can't build on Windows because of this problem. I was able to build with the revision 73b3906ba285 (from Feb 15).
I see this with Windows 7 32bit with vc10. I bisected it to:

The first bad revision is:
changeset:   170553:852fa926deae
user:        Ehsan Akhgari <ehsan@mozilla.com>
date:        Tue Feb 25 15:42:23 2014 -0500
summary:     Bug 976392 - Move moz2d to libxul; r=jrmuizel

Clobbering etc didn't help. I'll attach the short log and my mozconfig.
Blocks: 976392
Note I don't see this error on my Windows 7 64bit vm with vs2013.
Attached file build.log
Attachment #8383115 - Attachment mime type: text/x-log → text/plain
I also see this on the Windows box at my desk, which might be easier for Ehsan or Jeff to reproduce on.
In the log I see:

 3:49.93 Expanding Files Complete ...
 3:50.48 No rule to make target 'C:/Program' needed by ['<command-line>', 'C:/Program']
 3:50.48 No rule to make target 'Files/Microsoft' needed by ['<command-line>', 'Files/Microsoft']
 3:50.48 No rule to make target 'DirectX' needed by ['<command-line>', 'DirectX']
 3:50.48 No rule to make target 'SDK' needed by ['<command-line>', 'SDK']
 3:50.48 No rule to make target '(June' needed by ['<command-line>', '(June']
 3:50.48 No rule to make target '2010)/lib/x86/d3d9.lib' needed by ['<command-line>', '2010)/lib/x86/d3d9.lib']
 3:50.48 No rule to make target '2010)/lib/x86/dxguid.lib' needed by ['<command-line>', '2010)/lib/x86/dxguid.lib']
 3:50.61 libGLESv2.dll
 3:52.35    Creating library libGLESv2.lib and object libGLESv2.exp
 3:52.35 
 3:52.57 No rule to make target 'C:/Program' needed by ['<command-line>', 'C:/Program']
 3:52.57 No rule to make target 'Files/Microsoft' needed by ['<command-line>', 'Files/Microsoft']
 3:52.58 No rule to make target 'DirectX' needed by ['<command-line>', 'DirectX']
 3:52.58 No rule to make target 'SDK' needed by ['<command-line>', 'SDK']
 3:52.58 No rule to make target '(June' needed by ['<command-line>', '(June']
 3:52.58 No rule to make target '2010)/lib/x86/d3d9.lib' needed by ['<command-line>', '2010)/lib/x86/d3d9.lib']

This looks like a patch quoting issue which prevents the linker from finding d3d9.lib and dxguid.lib, which presumably contain the definition of that symbol.
Component: General → Build Config
Flags: needinfo?(mshal)
Flags: needinfo?(mh+mozilla)
Flags: needinfo?(gps)
I don't see that in my log, but I also don't see any references to d3d9.lib, iirc…
So, I looked at what happens on Blake's machine, and there this seemed like a quoting issue.  <http://mxr.mozilla.org/mozilla-central/source/toolkit/library/Makefile.in#244> causes the variables to end up unquoted on the command line on Blake's machine, but not on mine.  Note that Blake is using pymake and I'm using mozmake, but I don't know if that's relevant.

So then on my machine where I cannot reproduce the bug, I went to C:\Program Files (x86)\Microsoft DirectX SDK (June 2010)\Lib\x86 and grepped for IID_D2D1DeviceContext and didn't find anything!  Same results in the Visual Studio directory.  So now I don't even know which library is supposed to have this symbol.  Perhaps Bas knows?
Flags: needinfo?(bas)
OK, I think I found the bug, this is a regression from bug 970429, because of a missing initguid.h include.
Assignee: nobody → ehsan
Blocks: 970429
No longer blocks: 976392
Flags: needinfo?(mshal)
Flags: needinfo?(mh+mozilla)
Flags: needinfo?(gps)
Flags: needinfo?(bas)
https://hg.mozilla.org/mozilla-central/rev/91e94a667686
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: