977299 - [webvtt] Setting TextTrack::Mode to "hidden" should hide the cues from that track.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Rick Eyre (:reyre)]

The cues should be continued to be updated and a ActiveCueList should be maintained, but the cues should not be showed on the video.

Comment 1

[Rick Eyre (:reyre)]

Attachment: v1: Don't display subtitles if their mode is 'hidden' r=rillian

This patch will cause no tracks at all to display because we don't have automatic text track selection. So I think it's better to land 977302 before this one.

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8383087 [details] [diff] [review]
v1: Don't display subtitles if their mode is 'hidden' r=rillian

Review of attachment 8383087 [details] [diff] [review]:
-----------------------------------------------------------------

Agreed about waiting for text track selection before landing this. Otherwise we have a usability regression.

Comment 3

[Rick Eyre (:reyre)]

Attachment: v2: Don't display subtitles if their mode is 'hidden' r=rillian

Just rebasing against inbound.

Try looks green: https://tbpl.mozilla.org/?tree=Try&rev=9a0587215e2f

Carrying forward r=rillian.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae558b78b0d2

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ae558b78b0d2