Closed
Bug 977388
Opened 10 years ago
Closed 7 years ago
PREF_SYNC_SHOW_CUSTOMIZATION not cleared if setup is aborted
Categories
(Firefox :: Sync, defect, P3)
Tracking
()
RESOLVED
INVALID
People
(Reporter: rnewman, Unassigned, Mentored)
Details
(Whiteboard: [good first bug])
* Begin account creation. * Click "choose what to sync". * Verify email. * Click "cancel" when presented with datatype choices. * Quit the browser. * Relaunch. * Sign in with a different, pre-verified account. Actual: * See the verified screen. * Signing in shows me datatype choices, and they're wrong (all checked). Expected: * I don't see the verified screen. * PREF_SYNC_SHOW_CUSTOMIZATION is cleared when I cancel the setup process, so I don't see that datatype election doorhanger.
Comment 1•10 years ago
|
||
Rather than just setting a bool, let's set a string value to a hash of the account name. That way when we go to prompt, we can only do so if the hashes match. Not a blocker for 29, though, since this is a rare scenario (more likely that the same user will be signing in again, so showing them the prompt again is arguably a good thing).
No longer blocks: 969593
Updated•8 years ago
|
Mentor: markh
Whiteboard: [good first bug]
Updated•8 years ago
|
Priority: P2 → P3
Comment 2•7 years ago
|
||
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #1) > Rather than just setting a bool, let's set a string value to a hash of the > account name. That way when we go to prompt, we can only do so if the hashes > match. > > Not a blocker for 29, though, since this is a rare scenario (more likely > that the same user will be signing in again, so showing them the prompt > again is arguably a good thing). Hi, Is it worth fixing, If so I want to work on this. I'm new to contributing to Firefox, so would like to have your inputs on fixing this. Regards, Ganesh
Comment 3•7 years ago
|
||
(In reply to ganesh2583 from comment #2) > Is it worth fixing, If so I want to work on this. I'm new to contributing to > Firefox, so would like to have your inputs on fixing this. Hi Ganesh, Thanks for your interest, but this bug is no longer valid - that pref has already been deleted. https://www.joshmatthews.net/bugsahoy/ might be a good resource to find other bugs suitable for people new to contributing to Firefox.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•