977388 - PREF_SYNC_SHOW_CUSTOMIZATION not cleared if setup is aborted

Status: RESOLVED INVALID

(Firefox :: Sync, defect, P3)

Description

[Richard Newman [:rnewman]]

* Begin account creation.
* Click "choose what to sync".
* Verify email.
* Click "cancel" when presented with datatype choices.
* Quit the browser.
* Relaunch.
* Sign in with a different, pre-verified account.

Actual:
* See the verified screen.
* Signing in shows me datatype choices, and they're wrong (all checked).

Expected:
* I don't see the verified screen.
* PREF_SYNC_SHOW_CUSTOMIZATION is cleared when I cancel the setup process, so I don't see that datatype election doorhanger.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Rather than just setting a bool, let's set a string value to a hash of the account name. That way when we go to prompt, we can only do so if the hashes match.

Not a blocker for 29, though, since this is a rare scenario (more likely that the same user will be signing in again, so showing them the prompt again is arguably a good thing).

Comment 2

[Ganesh Chaitanya Kale]

(In reply to :Gavin Sharp [email: [e-mail]] from comment #1)
> Rather than just setting a bool, let's set a string value to a hash of the
> account name. That way when we go to prompt, we can only do so if the hashes
> match.
> 
> Not a blocker for 29, though, since this is a rare scenario (more likely
> that the same user will be signing in again, so showing them the prompt
> again is arguably a good thing).

Hi,

Is it worth fixing, If so I want to work on this. I'm new to contributing to Firefox, so would like to have your inputs on fixing this.

Regards,
Ganesh

Comment 3

[Mark Hammond [:markh] [:mhammond]]

(In reply to ganesh2583 from comment #2)
> Is it worth fixing, If so I want to work on this. I'm new to contributing to
> Firefox, so would like to have your inputs on fixing this.

Hi Ganesh,
  Thanks for your interest, but this bug is no longer valid - that pref has already been deleted. https://www.joshmatthews.net/bugsahoy/ might be a good resource to find other bugs suitable for people new to contributing to Firefox.