977393 - Fix build failure on gonk KK

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

Change of Bug 957323 breaks gonk KK build.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix build failure on gonk KK.

Comment 2

[Sotaro Ikeda [:sotaro]]

Waiting a confirmation.

Comment 3

[Sotaro Ikeda [:sotaro]]

There is still no test for gonk KK on tryserver. Then the build on gonk KK was not checked :-(

Comment 4

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8382670 [details] [diff] [review]
patch - Fix build failure on gonk KK.

peter, can you review the patch soon?

Comment 5

[Peter Chang[:pchang]]

I think we should add gonk KK on tryserver soon, do you know who should we contant to?

Comment 6

[Sotaro Ikeda [:sotaro]]

https://hg.mozilla.org/integration/b2g-inbound/rev/dfcedba04664

Comment 7

[Sotaro Ikeda [:sotaro]]

(In reply to peter chang[:pchang][:peter] from comment #5)
> I think we should add gonk KK on tryserver soon, do you know who should we
> contant to?


Yeah, it is necessary. I do not know about it.

And I just recognized that nexus-5 is almost useless because of Bug 965945's regression... gonk KK on tryserver is definitely necessary.

Comment 8

[Sotaro Ikeda [:sotaro]]

mwu, do you know who is a correct person to ask adding gonk KK on tryserver?

Comment 9

[Peter Chang[:pchang]]

chris, are you the right person to add gonk KK on tryserver?

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/dfcedba04664

Comment 11

[Sotaro Ikeda [:sotaro]]

(In reply to peter chang[:pchang][:peter] from comment #5)
> I think we should add gonk KK on tryserver soon, do you know who should we
> contant to?

It seems better Flatflsh(4.2) build is also on tryserver. Flatfish build is also broken. I recognize that by receiving a mail about it.

Comment 12

[Chris AtLee [:catlee]]

(In reply to peter chang[:pchang][:peter] from comment #9)
> chris, are you the right person to add gonk KK on tryserver?

we have very few device builds on try server for legal reasons. is there an emulator-kk target?

Comment 13

[Michael Wu [:mwu]]

(In reply to Chris AtLee [:catlee] from comment #12)
> we have very few device builds on try server for legal reasons. is there an
> emulator-kk target?

Yes.

I think we'll want emulator-kk builds on more than just try though - 1.4 brings in kk support.