977446 - Erroneous assertion in release_sync_buffer

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

This assertion is firing even when everything is working correctly. This needs to be fixed.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Potential fix

Comment 2

[Julian Seward [:jseward]]

This does appear to stop it asserting, yes.

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 8382770 [details] [diff] [review]
Potential fix

Review of attachment 8382770 [details] [diff] [review]:
-----------------------------------------------------------------

Julian is a better reviewer for this.

Comment 4

[Julian Seward [:jseward]]

Attachment: bug977446c4.diff

Rebased.

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Rebased fix with commit message

Comment 6

[Julian Seward [:jseward]]

Try results: https://tbpl.mozilla.org/?tree=Try&rev=d5ecfaf8ac46

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d6b4f6b09d2

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3d6b4f6b09d2