977448 - add build support for a 'MOZ_MOZILLA_API_KEY'

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Doug Turner (:dougt)]

Support a mozilla API key similar to the google API key for mozilla run services.

Comment 1

[Doug Turner (:dougt)]

Attachment: 0001-Add-MOZ_MOZILLA_API_KEY.patch

Comment 2

[Mike Hommey [:glandium]]

I understand why the google api key needs to live outside the tree, but does the mozilla one need to?

Comment 3

[Doug Turner (:dougt)]

same logic. :)

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8382747 [details] [diff] [review]
0001-Add-MOZ_MOZILLA_API_KEY.patch

Review of attachment 8382747 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/urlformatter/Makefile.in
@@ +3,4 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +export:: mozilla_api_key google_api_key

add yourself to GARBAGE too.

Comment 5

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d71b60afe52

Comment 6

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Backed out due to broken Android build:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a761b18588da
https://hg.mozilla.org/integration/mozilla-inbound/rev/01431ff08948
https://hg.mozilla.org/integration/mozilla-inbound/rev/6beb83e91a7d

https://tbpl.mozilla.org/php/getParsedLog.php?id=35459529&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=35460156&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=35460243&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=35459332&tree=Mozilla-Inbound

Comment 7

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e57e185fd67

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8e57e185fd67

Comment 9

[[:fabrice] Fabrice Desré]

 https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/a969ca483bd9