977450 - [WebApp][Manifest] Use "chrome": { "navigation": false } in app manifest makes a packaged app's chrome visible

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Omega Feng [:Omega] [:馮於懋]]

[Steps To Reproduce]
1. Use "chrome": { "navigation": false } in app manifest
2. Package the app
3. Install the app
4. Launch the app
 
[Actual Result]
The chrome is visible

[Expected Result]
The chrome is invisible


Device: Hamachi
OS Version: 1.4.0.0-prerelease
Platform Version: 30.0a1
Build Identifier: 20140226040201

Comment 1

[Jason Smith [:jsmith]]

Well that's definitely not right. Can you include a test case here? I want to understand if this is known or a regression.

Comment 2

[Omega Feng [:Omega] [:馮於懋]]

Attachment: ChromeTest.zip

Installing this test app on 1.3 or earlier version, there is no chrome.
But installing on 1.4, the chrome appears unexpectedly.

Device: Hamachi
OS Version: 1.4.0.0-prerelease
Platform Version: 30.0a1
Build Identifier: 20140226040201

Comment 3

[Gregor Wagner [:gwagner]]

Ben, Alive, any idea whats going on here?

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Taken first.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: Patch for master

Do not instantiate AppChrome if navigation is false.
I feel I should check 'chrome.title' as well but we don't have official naming for that so let it be.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

master
https://github.com/mozilla-b2g/gaia/commit/4d624378b96e57a77557af4f0808211a97ec3e39