Closed Bug 977452 Opened 6 years ago Closed 6 years ago
[keyboard refactor] Unit test for input
We need input_field.js covered by tests.
Assignee: nobody → gduan
waiting for travis
Comment on attachment 8394064 [details] [review] PR to master Hi Rudy, could you kindly help me to review this patch? Thanks.
Attachment #8394064 - Flags: review?(rlu)
Attachment #8394064 - Flags: review?(rlu) → review?(timdream)
Comment on attachment 8394064 [details] [review] PR to master Basically alright, thanks. - Please turn on the coverage report and see if your test script covers all functions. - I wonder if we want to break down mocks even further with separate MockEventTarget, MockInputMethod, and MockInputContext? Let's file a bug for that.
Attachment #8394064 - Flags: review?(timdream) → review+
In reply to comment 3, 1. this test has covered most important cases of original function and coverage is up to 90%. 2. open bug 987533 for MockEventTarget, MockInputMethod, and MockInputContex. Thanks, Tim. Master: https://github.com/mozilla-b2g/gaia/commit/012e02852fe7d14357e9d0b39f2ff2ca46c8728d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.