977544 - Mutt tests fail due to missing VK_ENTER

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect, P2)

Description

[Andrei Eftimie]

Fallout from bug 969247
It seems we still have some use for VK_ENTER.

Some mutt tests are failing.
I'll get this addressed.

Comment 1

[Andrei Eftimie]

Attachment: 0001-Bug-977544-Replace-VK_ENTER-with-VK_RETURN.-r-hskupi.patch

In the end it was just 1 affected test.
But we were leaving a context menu open and this would fail further tests bringing the total to 12 failed tests while running a complete mutt testrun.

All mutt tests are correctly passing now.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8382978 [details] [diff] [review]
0001-Bug-977544-Replace-VK_ENTER-with-VK_RETURN.-r-hskupi.patch

Review of attachment 8382978 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. Do you have access to push this, or would you like me to land it?

Comment 3

[Andrei Eftimie]

It would be great if you could land it, I am not a peer for mozmill.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed in:
https://github.com/mozilla/mozmill/commit/ccb290cae40c15531589102b8c51b5ac12d746ac

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dave, the patch should also have been landed on the hotfix-2.0 branch. So I cherry-picked it now:

https://github.com/mozilla/mozmill/commit/8d107f6585dd3d7c4beb9e92230fe86704bdec15

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Henrik Skupin (:whimboo) from comment #5)
> Dave, the patch should also have been landed on the hotfix-2.0 branch.

My mistake, sorry.