977596 - Fix build failure on flatfish (gonk JB4.2)

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

+++ This bug was initially created as a clone of Bug #977393 +++

Change of Bug 957323 breaks flatfish(gonk JB4.2) build.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix build failure on flatfish

Confirmed the fix on flatfish.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8383153 [details] [diff] [review]
patch - Fix build failure on flatfish

Review of attachment 8383153 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/GrallocTextureClient.cpp
@@ +222,3 @@
>    if (mReleaseFenceHandle.IsValid()) {
>      android::sp<Fence> fence = mReleaseFenceHandle.mFence;
> +#if ANDROID_VERSION == 17

// 1000 is what Android uses.

Comment 3

[Sotaro Ikeda [:sotaro]]

> -----------------------------------------------------------------
> 
> ::: gfx/layers/opengl/GrallocTextureClient.cpp
> @@ +222,3 @@
> >    if (mReleaseFenceHandle.IsValid()) {
> >      android::sp<Fence> fence = mReleaseFenceHandle.mFence;
> > +#if ANDROID_VERSION == 17
> 
> // 1000 is what Android uses.

It is a timeout until output warning log. I am going update the comment.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - Fix build failure on flatfish

Apply the comment. Carry "jmuizelaar: review+".

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - Fix build failure on flatfish

Comment 6

[Sotaro Ikeda [:sotaro]]

https://hg.mozilla.org/integration/b2g-inbound/rev/bb2d3f0b068b

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bb2d3f0b068b