977630 - [Single Variant] Builds Generation with Single Variant is not working

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[rafael.marquez]

*Procedire
1. Installing a master build on device
2. Clone the tests repository for sigle variant: https://github.com/telefonicaid/firefoxos-gaia-testsbuild.git
3. Configuring the file variant.json with a params similar to:

"id": "movistar",
      "mcc-mnc": [
        "214-001",
        "214-002",
        "214-005",
        "214-007"
      ],
4. Clone Gaia repository and select the master branch.
5. Executing the command "GAIA_DISTRIBUTION_DIR="URL"/firefoxos-gaia-testsbuild  PRODUCTION=1 make reset-gaia" to install gaia with single variant in the device
6.Complete FTE  with a movistar SIM with mnc/mcc 214/007


*Expected Result
Configured apps are installed

*Actual Result
Configured apps are not installed. If we have several mnc/mcc for a id, the configured apps are not installed

Comment 1

[Albert [:albert]]

After single variant refactor seems that generated singlevariantconf.json has wrong format, now has the following content:

{"214-001,214-002,214-005,214-007":["Calculator","Poppit","Wikipedia"],"734-004":["Twitter","Facebook","Accuweather","Wikipedia"]}

And it should besomething like:

"214-001":["Calculator","Poppit","Wikipedia"],
"214-002":["Calculator","Poppit","Wikipedia"],
"214-005":["Calculator","Poppit","Wikipedia"],
"214-007":["Calculator","Poppit","Wikipedia"],
"734-004":["Twitter","Facebook","Accuweather","Wikipedia"]

It makes mcc/mnc not being matched with "214-001,214-002,214-005,214-007", so applications are not installed.

Comment 2

[Albert [:albert]]

Yuren, can you confirm if the behavior commented on comment 1 is planned as a new way to do it or it is a bug?

Comment 3

[Jason Smith [:jsmith]]

(In reply to Albert [:albert] from comment #2)
> Yuren, can you confirm if the behavior commented on comment 1 is planned as
> a new way to do it or it is a bug?

We really shouldn't be switching these things around this much. We're going to run into unnecessary operator communication overhead if we keep changing the format.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

No, that's a bug. I'll fix it and add test case for it.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: github PR: https://github.com/mozilla-b2g/gaia/pull/16773

Comment 6

[Albert [:albert]]

Comment on attachment 8384412 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/16773

Thanks Yuren!

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged.

https://github.com/mozilla-b2g/gaia/commit/ba9fb61df3ba83757f575e16c3855319c88c5127