977637 - js/src/ctypes/msvcc.sh MPL2 change was not upstreamed

Status: RESOLVED WONTFIX

(mozilla.org :: Licensing, task)

Description

[Ryan VanderMeulen [:RyanVM]]

In bug 759095, the license header on js/src/ctypes/msvcc.sh was changed to MPL2. However, the change was not upstreamed to the libffi project. I am in the process of updating our in-tree clone of libffi and nearly clobbered the change in the process (only noticed it by accident).

Not sure what the policy for upstream imports is, so I don't know if this change was made in error and should be reverted or if it was intentional and needs upstreaming. If it's the latter, I'm actually working on getting some other in-tree patches upstreamed, so I can work on this while I'm at it :)

Comment 1

[Gervase Markham [:gerv]]

Hi RyanVM,

If we are not the originators of this code, then this change was made in error. We would encourage upstream projects to move to the MPL 2, but we don't MPL-2 our local copies of their code if they haven't moved.

So please feel free to revert the change. And also to recommend to libffi that they move any tri-licensed code they have to MPL 2 :-)

Gerv

Comment 2

[Ryan VanderMeulen [:RyanVM]]

This was rejected upstream. If anything, it should have been licensed under libffi's license in the first place. They're looking into what licensing that file should actually have, but for now, I'm going to go ahead and let the next upstream update clobber this change.

Thanks Gerv :)