Closed Bug 977672 Opened 6 years ago Closed 6 years ago

[I/O] Cleanup UnixSocket.{cpp,h}

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S2 (28feb)

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(3 files)

There is lots to cleanup in UnixSocket.{cpp,h}.
Right now, this patch only makes sure that our file descriptors are non-blocking. At some point, |SetSocketFlags| should be removed and it's functionality should be pushed into the |Create| method of the connectors. There we can set things like |O_CLOEXEC| without racing with concurrent calls to |fork|.
Attachment #8383141 - Flags: review?(kyle)
Attachment #8383141 - Flags: review?(kyle) → review+
Attachment #8383142 - Flags: review?(kyle) → review+
Attachment #8383144 - Flags: review?(kyle) → review+
This all looks good! Thanks for all the cleanup work, really happy to see this all getting easier to read/understand. :D
Depends on: 981239
You need to log in before you can comment on or make changes to this bug.