Closed
Bug 977688
Opened 10 years ago
Closed 10 years ago
Get rid of CC_AbortIfNull
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(1 file)
2.88 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
This method has MOZ_NEVER_INLINE on it, but PGO can merge it with MOZ_CRASHES in other places in the code (bug 971888) which makes things very confusing. This method is pretty simple, and only used a few places, so I should just inline it. It looks like it is really just null checking PtrInfo we pull out, so maybe we should instead null-check whatever fallible allocation is creating them.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8383192 -
Flags: review?(bugs)
Updated•10 years ago
|
Attachment #8383192 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f082a704d6d
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1f082a704d6d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•