977688 - Get rid of CC_AbortIfNull

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

This method has MOZ_NEVER_INLINE on it, but PGO can merge it with MOZ_CRASHES in other places in the code (bug 971888) which makes things very confusing.  This method is pretty simple, and only used a few places, so I should just inline it.  It looks like it is really just null checking PtrInfo we pull out, so maybe we should instead null-check whatever fallible allocation is creating them.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Get rid of CC_AbortIfNull.

Comment 2

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f082a704d6d

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1f082a704d6d