Closed Bug 977708 Opened 8 years ago Closed 8 years ago

Annotate crash reports with enabled experiments

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 31

People

(Reporter: gps, Assigned: benjamin)

References

Details

Attachments

(1 file)

We should annotate crash reports with the set of enabled telemetry experiments so we can correlate experiments to increased crash rates.
To clarify, there should only ever be one experiment at a time, so we really only need to annotate one, not a list. gps thanks for filing.
Assignee: nobody → benjamin
This should use the Experiments API from bug 974009.
Depends on: 974009
Attachment #8394781 - Flags: review?(felipc)
Comment on attachment 8394781 [details] [diff] [review]
telex-crash-annotate

Review of attachment 8394781 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/experiments/Experiments.jsm
@@ -600,5 @@
>  
> -    if (this._pendingTasks.updateManifest) {
> -      // We're already updating the manifest, no need to load the cached version.
> -      return this._pendingTasks.updateManifest;
> -    }

does this fix an existing bug, independent of the need to annotate the crash report? or does this just become necessary for the annotation?
No it's entirely unrelated, it just can't ever happen: we always load the cache from init() before we can ever have scheduled a manifest update.
Attachment #8394781 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/d8ee9252fc1f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.