977708 - Annotate crash reports with enabled experiments

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Gregory Szorc [:gps]]

We should annotate crash reports with the set of enabled telemetry experiments so we can correlate experiments to increased crash rates.

Comment 1

[Benjamin Smedberg]

To clarify, there should only ever be one experiment at a time, so we really only need to annotate one, not a list. gps thanks for filing.

Comment 2

[Georg Fritzsche [:gfritzsche]]

This should use the Experiments API from bug 974009.

Comment 3

[Benjamin Smedberg]

Attachment: telex-crash-annotate

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8394781 [details] [diff] [review]
telex-crash-annotate

Review of attachment 8394781 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/experiments/Experiments.jsm
@@ -600,5 @@
>  
> -    if (this._pendingTasks.updateManifest) {
> -      // We're already updating the manifest, no need to load the cached version.
> -      return this._pendingTasks.updateManifest;
> -    }

does this fix an existing bug, independent of the need to annotate the crash report? or does this just become necessary for the annotation?

Comment 5

[Benjamin Smedberg]

No it's entirely unrelated, it just can't ever happen: we always load the cache from init() before we can ever have scheduled a manifest update.

Comment 6

[Benjamin Smedberg]

https://hg.mozilla.org/integration/fx-team/rev/d8ee9252fc1f

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d8ee9252fc1f