Closed Bug 977730 Opened 7 years ago Closed 7 years ago

Count total pages visited by all test users

Categories

(Firefox :: Translation, defect)

x86_64
All
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 31

People

(Reporter: MarcoM, Assigned: mano)

References

Details

(Whiteboard: [translation] p=2 s=it-31c-30a-29b.2 [qa-])

Attachments

(1 file)

1.  Goal:
* As a product owner I want to measure the total number of pages that Beta Channel users in our test locales visit during the Translation test period so that I can control for behavioral variation between test groups

2.  Acceptance Criteria:
* I can view a report that shows me how many total pages each Beta Channel user of the Turkish, Vietnamese and Polish locales visited during the Translation test period
Depends on: 977768
Depends on: 977769
No longer depends on: 977769
No longer depends on: 977768
Depends on: 977768
from chat with bsmedberg
bsmedberg: I think we already measure something very much like that in telemetry
[11:24am] bsmedberg: the only thing being that we don't count it if the page doesn't finish loading...
[11:24am] bsmedberg: either the network fails or the user closes the tab before its done
[11:25am] chadw: ok, that's what i remember
[11:25am] bsmedberg: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#3966
[11:25am] bsmedberg: adding a counter there just for STATE_START would be trivial and wouldn't impact perf at all
No longer blocks: 973271
Whiteboard: [story] [translation] → [translation] p=0
Status: NEW → ASSIGNED
Whiteboard: [translation] p=0 → [translation] p=2 s=it-31c-30a-29b.1
Assignee: nobody → mano
I don't think this needs any special QA testing but I'm assigning it to Bogdan Maris as QA Contact for Translation. Please set to [qa+] if this needs manual testing.
QA Contact: bogdan.maris
Whiteboard: [translation] p=2 s=it-31c-30a-29b.1 → [translation] p=2 s=it-31c-30a-29b.1 [qa-]
Attached patch patch.diffSplinter Review
I'm not sure when should this expire. I set 35 as a placeholder.
Attachment #8396209 - Flags: review?(benjamin)
Comment on attachment 8396209 [details] [diff] [review]
patch.diff

Actually I don't think we should expire this. Total visits is a number we can use to correlate other data and as such I think it's reasonable to collect this permanently.
Attachment #8396209 - Flags: review?(benjamin) → review+
Since your backout also failed the same way, I'd start by betting that the Experiments build system is busted and requires a clobber.
https://tbpl.mozilla.org/php/getParsedLog.php?id=37018343&tree=Fx-Team, after the first two busted builds (https://tbpl.mozilla.org/php/getParsedLog.php?id=37013092&tree=Fx-Team and https://tbpl.mozilla.org/php/getParsedLog.php?id=37013943&tree=Fx-Team), was green. It doesn't admit to having been a clobber, but from a quick glance it looks like it probably was.
Whiteboard: [translation] p=2 s=it-31c-30a-29b.1 [qa-] → [translation] p=2 s=it-31c-30a-29b.2 [qa-]
And to muddy the waters even more, https://tbpl.mozilla.org/php/getParsedLog.php?id=37037489&tree=Fx-Team is a non-unified build which failed in the same way, long after your backout, on a slave which did not do a non-unified build (or any other sort of fx-team build, for that matter) while you were in the tree. Based on that, I can't tell you whether your patch needed a clobber, or you just got two very unlucky builds right after you landed, or what.
Actually, amidst the flames of mozilla-central burning after it got merged there, probably the best bet is that landing https://hg.mozilla.org/integration/fx-team/rev/5ab138b718fe required a clobber of all universal builds, and you were completely an innocent victim of it having just landed.
Thanks Phil. I'm going to try again now.
https://hg.mozilla.org/mozilla-central/rev/2ff1425ff217
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
The following changeset is now in Firefox Nightly:

> 2ff1425ff217 Bug 977730 - Count total pages visited by all test users. r=bsmedberg.

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central
Mass move of translation bugs to the new Translation component.
Component: Firefox Operations → Translation
Product: Tracking → Firefox
Target Milestone: --- → Firefox 31
Version: --- → Trunk
You need to log in before you can comment on or make changes to this bug.