977730 - Count total pages visited by all test users

Status: VERIFIED FIXED

(Firefox :: Translations, defect)

Description

[Marco Mucci [:MarcoM]]

1.  Goal:
* As a product owner I want to measure the total number of pages that Beta Channel users in our test locales visit during the Translation test period so that I can control for behavioral variation between test groups

2.  Acceptance Criteria:
* I can view a report that shows me how many total pages each Beta Channel user of the Turkish, Vietnamese and Polish locales visited during the Translation test period

Comment 1

[Chad Weiner [:chadw]]

from chat with bsmedberg
bsmedberg: I think we already measure something very much like that in telemetry
[11:24am] bsmedberg: the only thing being that we don't count it if the page doesn't finish loading...
[11:24am] bsmedberg: either the network fails or the user closes the tab before its done
[11:25am] chadw: ok, that's what i remember
[11:25am] bsmedberg: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#3966
[11:25am] bsmedberg: adding a counter there just for STATE_START would be trivial and wouldn't impact perf at all

Comment 2

[u279076]

I don't think this needs any special QA testing but I'm assigning it to Bogdan Maris as QA Contact for Translation. Please set to [qa+] if this needs manual testing.

Comment 3

[Asaf Romano (gone)]

Attachment: patch.diff

I'm not sure when should this expire. I set 35 as a placeholder.

Comment 4

[Benjamin Smedberg]

Comment on attachment 8396209 [details] [diff] [review]
patch.diff

Actually I don't think we should expire this. Total visits is a number we can use to correlate other data and as such I think it's reasonable to collect this permanently.

Comment 5

[Asaf Romano (gone)]

https://hg.mozilla.org/integration/fx-team/rev/93fd34169dd9

Comment 6

[Asaf Romano (gone)]

Very strange bustgae... backed-out:
https://hg.mozilla.org/integration/fx-team/rev/6b01c16172c2

Comment 7

[Phil Ringnalda (:philor)]

Since your backout also failed the same way, I'd start by betting that the Experiments build system is busted and requires a clobber.

Comment 8

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=37018343&tree=Fx-Team, after the first two busted builds (https://tbpl.mozilla.org/php/getParsedLog.php?id=37013092&tree=Fx-Team and https://tbpl.mozilla.org/php/getParsedLog.php?id=37013943&tree=Fx-Team), was green. It doesn't admit to having been a clobber, but from a quick glance it looks like it probably was.

Comment 9

[Phil Ringnalda (:philor)]

And to muddy the waters even more, https://tbpl.mozilla.org/php/getParsedLog.php?id=37037489&tree=Fx-Team is a non-unified build which failed in the same way, long after your backout, on a slave which did not do a non-unified build (or any other sort of fx-team build, for that matter) while you were in the tree. Based on that, I can't tell you whether your patch needed a clobber, or you just got two very unlucky builds right after you landed, or what.

Comment 10

[Phil Ringnalda (:philor)]

Actually, amidst the flames of mozilla-central burning after it got merged there, probably the best bet is that landing https://hg.mozilla.org/integration/fx-team/rev/5ab138b718fe required a clobber of all universal builds, and you were completely an innocent victim of it having just landed.

Comment 11

[Asaf Romano (gone)]

Thanks Phil. I'm going to try again now.

Comment 12

[Asaf Romano (gone)]

https://hg.mozilla.org/integration/fx-team/rev/2ff1425ff217

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ff1425ff217

Comment 14

[Firefox Commit Bot]

The following changeset is now in Firefox Nightly:

> 2ff1425ff217 Bug 977730 - Count total pages visited by all test users. r=bsmedberg.

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central

Comment 15

[Florian Quèze [:florian]]

Mass move of translation bugs to the new Translation component.