977756 - [Camera] Expose maxZoom on CameraControl

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Mike Habicher [:mikeh] (high bugzilla latency)]

Expose the AOSP CameraParameters::KEY_MAX_ZOOM value to JS.

We didn't do this before because we thought it was a static value that conveyed the length of the KEY_ZOOM_RATIOS list; but it looks like it may dynamically change to reflect the highest possible zoom given the current preview settings.

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: WIP - expose preview zoom limit attribute, v1

Preliminary version of patch; more mochitests forthcoming.

try-server push: https://tbpl.mozilla.org/?tree=Try&rev=873ffc615e59&showall=1

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Expose preview zoom limit attribute, v2

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 8384932 [details] [diff] [review]
Expose preview zoom limit attribute, v2

try-server push: https://tbpl.mozilla.org/?tree=Try&rev=c81fd9cf5f94

Comment 4

[Dave Hylands [:dhylands]]

Comment on attachment 8384932 [details] [diff] [review]
Expose preview zoom limit attribute, v2

Review of attachment 8384932 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 5

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: WIP - expose preview zoom limit attribute, v3 r=dhylands

Fix JB build breakage; carrying r+ forward.

try-server push: https://tbpl.mozilla.org/?tree=Try&rev=bb2129b7d477&showall=1

Comment 6

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8385364 [details] [diff] [review]
WIP - expose preview zoom limit attribute, v3 r=dhylands

From http://developer.android.com/reference/android/hardware/Camera.Parameters.html#getMaxZoom() :

`This value may change in different preview size. Applications should call this again after setting preview size.`

However, with this patch, it seems to always return the maximum value from the `zoomRatios` array (which is `4.0` on helix and nexus4). This seems to be incorrect behavior because the `zoom` attribute only affects the preview up to a certain point (depending on the `previewSize`) and then it stops causing any further visual changes to the preview after that point.

I seem to have found a formula for determining what the maximum `zoom` is for the current `previewSize` without this attribute. See bug 933902 for specifics.

Comment 7

[Mike Habicher [:mikeh] (high bugzilla latency)]

I've confirmed Justin's findings in comment 6: the value returned by KEY_MAX_ZOOM never changes. I don't think there's much more to do here given that this parameter is essentially returning capabilities.zoomRatios.length.

Comment 8

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Expose preview zoom limit attribute, v4 r=dhylands

Only the DOM-facing changes; the Gecko-only changes have been bumped to bug 980484.

Comment 9

[Mike Habicher [:mikeh] (high bugzilla latency)]

I'm closing this because it doesn't work the way we need it to. Nothing more to see here.