977759 - SharedArrayBuffer breaks --disable-ion builds

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gregor Wagner [:gwagner]]

I can't build an --enable-debug gecko for a b2g phone any more.

Even after a clobber I am getting
/Volumes/disc2/code/leo/B2G/prebuilt/darwin-x86/toolchain/arm-linux-androideabi-4.4.x/bin/../lib/gcc/arm-linux-androideabi/4.4.3/../../../../arm-linux-androideabi/bin/ld: ../libjs_static.a(Unified_cpp_js_src5.o): in function js::SharedArrayRawBuffer::New(unsigned int):/Volumes/mac/moz/ib2g/js/src/vm/SharedArrayObject.cpp:76: error: undefined reference to 'js::IsValidAsmJSHeapLength(unsigned int)'
/Volumes/disc2/code/leo/B2G/prebuilt/darwin-x86/toolchain/arm-linux-androideabi-4.4.x/bin/../lib/gcc/arm-linux-androideabi/4.4.3/../../../../arm-linux-androideabi/bin/ld: ../libjs_static.a(Unified_cpp_js_src5.o): in function js::SharedArrayBufferObject::New(JSContext*, unsigned int):/Volumes/mac/moz/ib2g/js/src/vm/SharedArrayObject.cpp:179: error: undefined reference to 'js::IsValidAsmJSHeapLength(unsigned int)'
/Volumes/disc2/code/leo/B2G/prebuilt/darwin-x86/toolchain/arm-linux-androideabi-4.4.x/bin/../lib/gcc/arm-linux-androideabi/4.4.3/../../../../arm-linux-androideabi/bin/ld: ../libjs_static.a(Unified_cpp_js_src5.o): in function js::SharedArrayBufferObject::New(JSContext*, unsigned int):/Volumes/mac/moz/ib2g/js/src/vm/SharedArrayObject.cpp:182: error: undefined reference to 'js::RoundUpToNextValidAsmJSHeapLength(unsigned int)'
collect2: ld returned 1 exit status

Comment 1

[Sean Stangl [:sstangl]]

js/src/vm/SharedArrayBuffer.cpp is missing |#include "jit/AsmJS.h"|. This wasn't noticed on other platforms because of unified builds (and even passed Tryserver! https://tbpl.mozilla.org/?tree=Try&rev=0c8831ec51b7).

Comment 2

[Sean Stangl [:sstangl]]

Oh, nevermind, that correct file is included. Is AsmJS.cpp not being built on b2g builds?

Comment 3

[Jan Beich]

--disable-ion is indeed busted as seen on Linux powerpc64

http://mozillaproject.osuosl.org:8010/builders/runtests/builds/1044/steps/shell/logs/stdio

Comment 4

[Gregor Wagner [:gwagner]]

Well Ion should be enabled:
http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#1983

Comment 5

[Gregor Wagner [:gwagner]]

I had a --disable-ion in my mozconfig and I hope my problem is fixed now. But the general problem that we can't compile without ion still holds.

Comment 6

[Sean Stangl [:sstangl]]

Attachment: patch

Moves RoundUpToNextValidAsmJSHeapLength() and IsValidAsmJSHeapLength() to jit/AsmJS.h, so vm/SharedArrayBuffer.cpp can include them even if --disable-ion.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1663c434abc0

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1663c434abc0