977828 - [Windows] The color picker can be opened simultaneously in two windows

Status: NEW

(Core :: Layout: Form Controls, defect)

Description

[Gabriela [:gaby2300]]

Bug found using Windows 7 64 bit and Windows XP and Firefox 28 Beta 6.
Build ID: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0
Build config: Built from https://hg.mozilla.org/releases/mozilla-beta/rev/303a852bcba5

As per Moztrap testcase #11269 (https://moztrap.mozilla.org/results/case/374160/)

1. Start 2 Firefox windows
2. Open http://diveintohtml5.info/examples/input-type-color.html simultaneously in both windows
3. Open the color picker in both windows
4. Notice you can open the color picker in both windows

Actual result: You can open the color picker in both windows
Expected result: You shouldn't be able to open the color picker twice

Comment 1

[Daniel Holbert [:dholbert]]

[backstory: this isn't inherently a bad thing; it's only a bug because bug 944737 should've disabled the ability to do this (on Windows) to work around an issue that happens when two colorpickers are open. See that bug for more detail.]

(In reply to Gabriela from comment #0)
> 1. Start 2 Firefox windows

Gabriela -- to clarify -- are you actually starting two different Firefox *processes* here (with different profiles)?

Or are you starting a single firefox process, and doing File | New Window (or equivalently Ctrl+N) to open the second window?

Comment 2

[Gabriela [:gaby2300]]

(In reply to Daniel Holbert [:dholbert] from comment #1)
> [backstory: this isn't inherently a bad thing; it's only a bug because bug
> 944737 should've disabled the ability to do this (on Windows) to work around
> an issue that happens when two colorpickers are open. See that bug for more
> detail.]
> 
> (In reply to Gabriela from comment #0)
> > 1. Start 2 Firefox windows
> 
> Gabriela -- to clarify -- are you actually starting two different Firefox
> *processes* here (with different profiles)?
> 
> Or are you starting a single firefox process, and doing File | New Window
> (or equivalently Ctrl+N) to open the second window?

I am sorry but Moztrap testcase #11269 Step one mentions 2 Firefox windows. It doesn't mention 2 Firefox processes nor different profiles.

Comment 3

[Daniel Holbert [:dholbert]]

I'm just clarifying, because "Start 2 Firefox Windows" is a bit ambiguous, and if you happened to be  starting 2 firefox processes [unlikely], then what you're seeing would be the expected behavior.


So to clarify: your step 1 can be broken down into:
 1a) Start Firefox
 1b) File | New Window, to create a second window
correct?

Comment 4

[Gabriela [:gaby2300]]

(In reply to Daniel Holbert [:dholbert] from comment #3)
> I'm just clarifying, because "Start 2 Firefox Windows" is a bit ambiguous,
> and if you happened to be  starting 2 firefox processes [unlikely], then
> what you're seeing would be the expected behavior.
> 
> 
> So to clarify: your step 1 can be broken down into:
>  1a) Start Firefox
>  1b) File | New Window, to create a second window
> correct?

Yes Daniel, correct!

Comment 5

[Daniel Holbert [:dholbert]]

OK, thanks. It was a long shot, but I thought that might've been the explanation. :)

In that case, I'm still mystified as to what's making it so you can trigger this bug whereas Arnaud and I can't.

If it's all right with you, it might make sense for us to make a modified build, with some logging added, and have you run that & report back about what the logging is saying. [which hopefully can narrow down the area of mystery here]

Comment 6

[Gabriela [:gaby2300]]

If I can use the modified build with a new profile or with a copy of an old one, please go ahead! I'll be looking forward to running it and help solve the mystery!

Comment 7

[Arnaud Bienner]

(In reply to Daniel Holbert [:dholbert] from comment #5)
> If it's all right with you, it might make sense for us to make a modified
> build, with some logging added, and have you run that & report back about
> what the logging is saying. [which hopefully can narrow down the area of
> mystery here]

We can do this by pushing some modified code (more logging) to try right? The built binaries remain available for some time after isn't it?

Comment 8

[Arnaud Bienner]

Also, https://moztrap.mozilla.org/results/case/374160/ is partially wrong: it doesn't mention this behavior should happen for Windows only.
Thus, as a result, someone marked it as failed as Linux (while on Linux we allow two color pickers to be opened at a time because we don't have the same system limitation).
Do you know who can fix this?

Comment 9

[Arnaud Bienner]

I guess you created this case Manuela :) Could you please correct the description to clarify it's Windows specific? (see my previous comment 8)

Comment 10

[Manuela Muntean [Away]]

Hi Arnaud! Sure, I've updated the https://moztrap.mozilla.org/manage/case/11269/ testcase.

Comment 11

[Arnaud Bienner]

OK thanks a lot :)
Actually, I would have said "If you're under Linux, another color picker will be opened". That sounds clearer to me.
Probably worth to specify what is expected for OS X but, as the OS X implementation is currently buggy (bug 976724 and bug 975468) we will probably change the current behavior and I'm not sure what we will have at the end.

Comment 12

[Daniel Holbert [:dholbert]]

(In reply to Arnaud Bienner from comment #7)
> We can do this by pushing some modified code (more logging) to try right?
> The built binaries remain available for some time after isn't it?

Yeah, that's what I had in mind. (Try TBPL has a "go to build directory" link, too, when you've clicked on a "B", which takes you directly to the binaries, and I believe they last for at least a couple weeks)