977885 - Missing revision on change when .sync from Data Store

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[Dale Harvey (:daleharvey)]

I write 3 objects in one app (the system app), I get 2 updates inside a single .sync cursor loop

https://gist.github.com/daleharvey/9261361 is a log of what happens, you can see the object with iconUri saved is never received

The code for this is around https://github.com/mozilla-b2g/gaia/blob/master/apps/search/js/providers/places.js#L29

Comment 1

[(no longer active)]

Andrea, can you please take a look?  Thanks!

Comment 2

[Andrea Marchesini [:baku]]

I don't think there is no bug here. The value is overwritten 3 times. Search app uses the cursor to update itself. The cursor skips the intermediate value and brings search app to the latest version, latest data:

[SYSTEM] SAVED {"url":"http://localhost:53970/favicon.html","title":"Sample page","frecency":1}
[SYSTEM] REVISION {dbe8c427-94db-1340-a225-b89d18843d5b}
 
[SEARCH] I GOT SOMETHING { operation: 'update',
id: 'http://localhost:53970/favicon.html',
data: { url: 'http://localhost:53970/favicon.html', title: 'Sample page', frecency: 1 } }
...
[SEARCH] SYNC DONE AT {dbe8c427-94db-1340-a225-b89d18843d5b}

Comment 3

[Dale Harvey (:daleharvey)]

confirmed that that isnt the bug, it was an incorrect assumption on the event loop related to datastore operations

https://bugzilla.mozilla.org/show_bug.cgi?id=963038#c10