977920 - MmsService should not check for nsIDOMMozGsmIccInfo when retrieving iccId

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Carol Yang [:cyang]]

Reference: http://dxr.mozilla.org/mozilla-central/source/dom/mobilemessage/src/gonk/MmsService.js#318

Since iccId applies to both GSM and CDMA, seems like this check should be removed:
!(iccInfo instanceof Ci.nsIDOMMozGsmIccInfo)

Comment 1

[Jason Smith [:jsmith]]

What's the user impact of this bug? Why is this needed for 1.4 FC?

Comment 2

[Carol Yang [:cyang]]

(In reply to Jason Smith [:jsmith] from comment #1)
> What's the user impact of this bug? Why is this needed for 1.4 FC?

Please note that bugzilla 975356 will now broadcast iccId for both incoming MMS and SMS. Without the fix suggested in comment 0, we would not know which SIM the message is received on, which ultimately breaks bugzilla 947180.

Comment 3

[Julien Wajsberg [:julienw]]

This is for Bevis

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

The same symptom in RadioInterfaceLayer.js:
http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js#2296

Comment 5

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch v1: Bug 977920 - Retrieving iccId without checking prototype of IccInfo. r=vyang

Tested with both USIM/RUIM.
The IccId could be retrieved correctly without check the prototype of IccInfo.

Comment 6

[Bevis Tseng[:bevis][:btseng](Exited)]

try sever result is green.
https://tbpl.mozilla.org/?tree=Try&rev=54df34276b47

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d2a87aeafacc

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d2a87aeafacc

Comment 9

[Brogan Zumwalt [Inactive]]

No STR is present to create test case to address bug.

Comment 10

[KTucker [:KTucker][Inactive 3/4/2016]]

Not enough information to create a test case.