Closed Bug 977920 Opened 7 years ago Closed 7 years ago

MmsService should not check for nsIDOMMozGsmIccInfo when retrieving iccId

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.4+, firefox28 wontfix, firefox29 wontfix, firefox30 fixed, b2g-v1.4 fixed)

RESOLVED FIXED
1.4 S3 (14mar)
blocking-b2g 1.4+
Tracking Status
firefox28 --- wontfix
firefox29 --- wontfix
firefox30 --- fixed
b2g-v1.4 --- fixed

People

(Reporter: cyang, Assigned: bevis)

Details

(Whiteboard: [FT:RIL])

Attachments

(1 file)

Reference: http://dxr.mozilla.org/mozilla-central/source/dom/mobilemessage/src/gonk/MmsService.js#318

Since iccId applies to both GSM and CDMA, seems like this check should be removed:
!(iccInfo instanceof Ci.nsIDOMMozGsmIccInfo)
What's the user impact of this bug? Why is this needed for 1.4 FC?
(In reply to Jason Smith [:jsmith] from comment #1)
> What's the user impact of this bug? Why is this needed for 1.4 FC?

Please note that bugzilla 975356 will now broadcast iccId for both incoming MMS and SMS. Without the fix suggested in comment 0, we would not know which SIM the message is received on, which ultimately breaks bugzilla 947180.
blocking-b2g: 1.4? → 1.4+
Component: General → DOM: Device Interfaces
Product: Firefox OS → Core
Version: unspecified → Trunk
This is for Bevis
Component: DOM: Device Interfaces → RIL
Flags: needinfo?(btseng)
Product: Core → Firefox OS
Version: Trunk → unspecified
Assignee: nobody → btseng
Flags: needinfo?(btseng)
Tested with both USIM/RUIM.
The IccId could be retrieved correctly without check the prototype of IccInfo.
Attachment #8385872 - Flags: review?(vyang)
Attachment #8385872 - Flags: review?(vyang) → review+
Whiteboard: [FT:RIL]
Target Milestone: --- → 1.4 S3 (14mar)
https://hg.mozilla.org/mozilla-central/rev/d2a87aeafacc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
No STR is present to create test case to address bug.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Flags: in-moztrap?(bzumwalt)
Not enough information to create a test case.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Flags: in-moztrap?(bzumwalt)
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.