977931 - hawkclient fails to throw the correct error when no response headers.

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0003-Bug-return-an-error-object-even-when-restResponse.he.patch

STR:
* Start Fx with a signed in user, but with no internet connection available
* Attempt to login.

Actual:
* Message appears in the log:

1393550554715	FirefoxAccounts	DEBUG	(Response) code: null - Status text: null
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "[JavaScript Error: "restResponse.headers is null" {file: "resource://services-common/hawkclient.js" line: 74}]'[JavaScript Error: "restResponse.headers is null" {file: "resource://services-common/hawkclient.js" line: 74}]' when calling method: [nsIStreamListener::onStopRequest]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
************************************************************

and the correct error isn't propagated to the client.

Expected:
* Opposite of the above :)

Problem is that in this scenario, restResponse.headers is null, so attempting to access restResponse.headers["retry-after"] fails.

This is a regression caused by bug 945449

Comment 1

[Sam Penrose]

Comment on attachment 8383423 [details] [diff] [review]
0003-Bug-return-an-error-object-even-when-restResponse.he.patch

Thanks for the catch and the quick fix!

Comment 2

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/2bc564e6e33d

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/2bc564e6e33d

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8383423 [details] [diff] [review]
0003-Bug-return-an-error-object-even-when-restResponse.he.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 945449
User impact if declined: Sync will do strange things in some error cases.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low - fix for bug 945449
String or IDL/UUID changes made by this patch: None

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Fixed on aurora via the push in bug 945449 - 
https://hg.mozilla.org/releases/mozilla-aurora/rev/b91a791d42b8