977954 - CustomizableUI tests fail on Win8 when not built with --enable-metro

Status: RESOLVED DUPLICATE of bug 978127

(Firefox :: Toolbars and Customization, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Jared noticed that our CustomizableUI tests fail on Win8 when the build hasn't been built with --enable-metro. AFAIK, the build slaves always build on Windows with --enable-metro. I'd guess that many contributors wouldn't add --enable-metro, and generally shouldn't need to unless they're working on that (it adds unneeded time to the build process). So we should fix that sooner rather than later.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Specifically this is because the Switch To Metro button is not added to the menu panel unless --enable-metro is defined, and many of the tests check the runtime environment to determine if the button should be present.

Comment 2

[Jim Mathies [:jimm]]

Hmm, shouldn't the Services.metro test catch this cas?

http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/Services.jsm#88

Comment 3

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #2)
> Hmm, shouldn't the Services.metro test catch this cas?
> 
> http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/Services.jsm#88

ah, nm, this is caused by bug 978127. That catch does work, but the customized ui tests aren't up to date.