977961 - mach mercurial-setup always prompts about mqext's autocommit

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Gregory Szorc [:gps]]

mach mercurial-setup now always prompts about enabling mqext's autocommit setting, even if it's already enabled. Likely regression from bug 977384.

Comment 1

[Ed Morley [:emorley]]

Attachment: Avoid prompting to enable mqext auto-commit when already enabled

Sorry I overlooked this in bug 977384 - I'd seen that many of the other checks verified before running, and didn't notice that this one did not do that.

Note the "if 'mqext' in c.extensions and not c.have_mqext_autocommit_mq():" is so the wrapping doesn't look awful - and the prior "if 'mqext' in c.extensions:" will be removed soon (once I import mqext into version-control-tools), so this way whilst slightly redundant now will avoid more churn later.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8383704 [details] [diff] [review]
Avoid prompting to enable mqext auto-commit when already enabled

Review of attachment 8383704 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 3

[Ed Morley [:emorley]]

Ty :-)

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/39101e03fc13

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/39101e03fc13