Closed Bug 977961 Opened 6 years ago Closed 6 years ago

mach mercurial-setup always prompts about mqext's autocommit

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: gps, Assigned: emorley)

References

Details

Attachments

(1 file)

mach mercurial-setup now always prompts about enabling mqext's autocommit setting, even if it's already enabled. Likely regression from bug 977384.
Sorry I overlooked this in bug 977384 - I'd seen that many of the other checks verified before running, and didn't notice that this one did not do that.

Note the "if 'mqext' in c.extensions and not c.have_mqext_autocommit_mq():" is so the wrapping doesn't look awful - and the prior "if 'mqext' in c.extensions:" will be removed soon (once I import mqext into version-control-tools), so this way whilst slightly redundant now will avoid more churn later.
Attachment #8383704 - Flags: review?(gps)
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Comment on attachment 8383704 [details] [diff] [review]
Avoid prompting to enable mqext auto-commit when already enabled

Review of attachment 8383704 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8383704 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/39101e03fc13
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.