978003 - Update inContentUI.css for Windows 8 and up

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Peter Henkel [:Terepin]]

Attachment: ICUI inside Modern theme.png

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140227030203

Steps to reproduce:

ICUI has still Aero theme, which looks out of place, now even more since bug 960517 landed. This bug is about "about" pages in general. I will fill separate bugs for each "about" page if needed.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8386044 [details] [diff] [review]
patch

Review of attachment 8386044 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks Dão!

I didn't know about the `-moz-windows-glass` media query (not consciously, at least)... handy!

Comment 3

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/c368136afb26

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c368136afb26

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8386044 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 960517
User impact if declined: visual mismatch on Windows 8
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 6

[Peter Henkel [:Terepin]]

Dao, add-ons list and section selector should be squared and not rounded. Shall I fill bug for it?

Comment 7

[Mike de Boer [:mikedeboer]]

Peter, that is a good idea. This bug is about adjusting the general styles used across in-content pages. The UI element of specific pages are not considered part of this bug. It's going to be a lot of work, but each in-content page will need to be reviewed and adjusted separately. A bug should be filed for each of them.

Comment 8

[Mike de Boer [:mikedeboer]]

(I meant that filing a bug is a good idea)

Comment 9

[Peter Henkel [:Terepin]]

Is "squaring" a valid English word? :)

Comment 10

[Mike de Boer [:mikedeboer]]

As far as I'm concerned, it is now! :)

Comment 11

[Peter Henkel [:Terepin]]

Filled. Please, review it and I'll fill rest of the reports accordingly. Thanks.

Comment 12

[Peter Henkel [:Terepin]]

Eh, are there plans to restyle about:support?

Comment 13

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/602a86a948f6

Comment 14

[Tim Nguyen :ntim]

With this bug fixed, the addon buttons (Disable, Remove,...) have the native styling on Windows 8. Not sure if that is expected.

Comment 15

[Cornel Ionce [:noni] [Hubs QA]]

Dao, can you confirm if Tim's results are expected or not?

Comment 16

[Dão Gottwald [:dao]]

I think that's expected. Using the native, flat and square button styling is in line the other Win 8 theme adjustments in inContentUI.css and elsewhere.

Comment 17

[Cornel Ionce [:noni] [Hubs QA]]

In that case I'm marking this issue verified. Thank you!
# Fx 29 beta 8: 20140414143035
# Latest Aurora: 20140416004008