978045 - Move plugin tests in browser/base/content/tests/general to browser/base/content/tests/plugins

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Georg Fritzsche [:gfritzsche]]

I often find myself wanting to run just the plugin/click-to-play tests to verify my changes - running all the general/ tests still takes too long.

I would like to move all plugin related tests (mostly browser_CTP_*, browser_pluginnotification.js, ...) to:
browser/base/content/test/plugins

Comment 1

[Georg Fritzsche [:gfritzsche]]

jaws, any objections?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

go for it!

Comment 3

[Georg Fritzsche [:gfritzsche]]

Attachment: move bc plugin tests to browser/base/content/test/plugins/

https://tbpl.mozilla.org/?tree=Try&rev=cc63af86adca

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8384566 [details] [diff] [review]
move bc plugin tests to browser/base/content/test/plugins/

Review of attachment 8384566 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me, assuming you make sure that these are running on tbpl and all of the tests pass.

Comment 5

[Georg Fritzsche [:gfritzsche]]

Attachment: move bc plugin tests to browser/base/content/test/plugins/, v2

The social/ tests have a dependency on general/blockNoPlugins.xml, which moved.

Comment 6

[Georg Fritzsche [:gfritzsche]]

https://tbpl.mozilla.org/?tree=Try&rev=0d29ced6648

Comment 7

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d369fc64e91

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9d369fc64e91