Closed Bug 978063 Opened 7 years ago Closed 7 years ago

[BuildingBlocks] Favor scroll performance over thumbnails quality

Categories

(Firefox OS Graveyard :: Gaia, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S4 (28mar)

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

(Keywords: perf, Whiteboard: [c=handeye p= s=2014.03.28 u=])

Attachments

(1 file)

This helps reducing checkerboarding in Gallery and Music. I assume it should help for other apps as well.

The change in quality is mostly visible for square part from my testing, which should not affect too much persons pictures.
Attachment #8383624 - Flags: review?(arnau)
Summary: Favor scroll performance over thumbnail quality → Favor scroll performance over thumbnails quality
Summary: Favor scroll performance over thumbnails quality → [BuildingBlocks] Favor scroll performance over thumbnails quality
Keywords: perf
Whiteboard: [c=handeye p= s= u=]
Vivien,
I don't really know how should I test this :)
I have tested contacts list using "make reference-workload-light".
I cannot notice any difference with and without your patch, nor in performance neither in image quality.
But contacts app is not showing the images until scroll stops, so maybe is there when the image quality decreases?
Do you have any performance test to see how this property impacts?
Flags: needinfo?(21)
(In reply to Arnau March  [:arnau] from comment #1)
> Vivien,
> I don't really know how should I test this :)
> I have tested contacts list using "make reference-workload-light".
> I cannot notice any difference with and without your patch, nor in
> performance neither in image quality.
> But contacts app is not showing the images until scroll stops, so maybe is
> there when the image quality decreases?

For contacts apps the image quality is decreased slightly when the image is shown. So I won't expect a real performance gain here.

I expect more some win in things like the call log for example. Where if I have the image of someone (let's say my girlfriend) and if this is person is calling me everyday, or I, then it will be a lot of images.

> Do you have any performance test to see how this property impacts?

I don't have performances tests but using that in Gallery and Music has reduced the checkerboarding for me. It seems like this is faster to repaint images using this algorithm.
Flags: needinfo?(21)
Comment on attachment 8383624 [details] [diff] [review]
bb.favor.performance.over.quality.patch

I cannot see image quality decreased, so LGTM!
Attachment #8383624 - Flags: review?(arnau) → review+
https://github.com/mozilla-b2g/gaia/commit/68493493f5cfa84d9674c4e642371aa7c6e20119
Assignee: nobody → 21
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [c=handeye p= s= u=] → [c=handeye p= s=2014.03.28 u=]
Target Milestone: --- → 1.4 S4 (28mar)
You need to log in before you can comment on or make changes to this bug.