978147 - g_type_init is deprecated and does nothing

Status: RESOLVED DUPLICATE of bug 1114898

(Toolkit :: General, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

From https://developer.gnome.org/gobject/stable/gobject-Type-Information.html#g-type-init :

> g_type_init has been deprecated since version 2.36 and should not be used in newly-written code. the type system is now initialised automatically

Unless we need to be able to build with gobject < 2.36 (which doesn't seem to be supported anymore: https://developer.gnome.org/gobject/ ), it seems like we can get rid of some unnecessary things and remove a compiler warning.

Comment 1

[raymond [:retornam] (inactive)]

Attachment: bug-978147.patch

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8384843 [details] [diff] [review]
bug-978147.patch

Review of attachment 8384843 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but I'm not a toolkit peer, so I can't r+ this. Marking f+. Someone from https://wiki.mozilla.org/Modules/All#Toolkit should look at this (preferably someone with gnome expertise).

::: toolkit/system/gnome/nsGnomeModule.cpp
@@ +65,1 @@
>  

nit: we probably don't need this extra blank line

Comment 3

[raymond [:retornam] (inactive)]

Attachment: bug-978147.patch

Comment 4

[Brian R. Bondy [:bbondy]]

Comment on attachment 8386240 [details] [diff] [review]
bug-978147.patch

Review of attachment 8386240 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I'm not the best person for this review, maybe roc can review or delegate to someone.

Comment 5

[raymond [:retornam] (inactive)]

Thanks Roc.

Comment 6

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/00a76d6b935c

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/082bae16fc33 for apparently breaking Linux mochitests. They're all failing like this: https://tbpl.mozilla.org/php/getParsedLog.php?id=35746723&tree=Fx-Team

Comment 8

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

(In reply to David Keeler (:keeler) from comment #0)
> Unless we need to be able to build with gobject < 2.36 (which doesn't seem
> to be supported anymore: https://developer.gnome.org/gobject/ ), it seems
> like we can get rid of some unnecessary things and remove a compiler warning.

Shoot - I misread that page. It looks like we're using 2.32.1, which is still supported, which does require g_type_init. So, that was a waste of time. My apologies, everyone.