Closed Bug 978348 Opened 6 years ago Closed 6 years ago

PresShell::SetDisplayPort is dead code, remove it

Categories

(Core :: Layout, defect, P4, trivial)

defect

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: tnikkel, Assigned: tnikkel)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This has been dead for a while.
Attachment #8384015 - Flags: review?(dholbert)
Comment on attachment 8384015 [details] [diff] [review]
patch

For the record:

This method was added in bug 590294...
  http://hg.mozilla.org/mozilla-central/rev/a5f171570672#l4.104
...and deprecated (along with GetDisplayPort) in the nsIPresShell interface in bug 618975:
  http://hg.mozilla.org/mozilla-central/rev/dea535299cf2#l8.8
...and then the nsIPresShell (superclass) decl was removed entirely in bug 617539:
  https://hg.mozilla.org/mozilla-central/rev/0dc8fb9d0bc3#l3.169

If we'd been using MOZ_OVERRIDE at the time, we would have noticed this stale impl immediately. :)

r=me
Attachment #8384015 - Flags: review?(dholbert) → review+
Assignee: nobody → tnikkel
Severity: normal → trivial
Flags: in-testsuite-
OS: Mac OS X → All
Priority: -- → P4
Hardware: x86 → All
Version: 29 Branch → Trunk
Thanks for doing the code archeology!
https://hg.mozilla.org/mozilla-central/rev/a59df9b7ca48
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.