Closed Bug 978373 Opened 7 years ago Closed 7 years ago

[l10n][[Settings] Fix l10n for developer-hud

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

defect
Not set
normal

Tracking

(b2g-v1.4 fixed)

RESOLVED FIXED
1.4 S3 (14mar)
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: tchevalier, Assigned: tchevalier)

References

Details

Attachments

(1 file)

The wrong l10n id is being used for jank threshold in en-US file:
"jank-threshold" should be "hud-jank-threshold" instead.

Two strings are used for title, button and the setting itself. Should be 3 different strings, see bug 950463.
Hey Kazé, could you look into this?

Note that I reworded the l10n comment a bit, and Travis failing as usual (unrelated to the patch).
Attachment #8384040 - Flags: review?(kaze)
Théo, thanks for keeping an eye out for consistency! Looks good to me with one nit.

Please keep in mind that changing l10n keys requires localizers to translate corresponding strings again (see Pike's comments in bug #963498). In general, if a key's naming is bad, but no change is required in the translation, we try to keep it as is.
(In reply to Jan Keromnes [:janx] from comment #2)
> Théo, thanks for keeping an eye out for consistency! Looks good to me with
> one nit.
> 
> Please keep in mind that changing l10n keys requires localizers to translate
> corresponding strings again (see Pike's comments in bug #963498). In
> general, if a key's naming is bad, but no change is required in the
> translation, we try to keep it as is.

As French Gaia localizer working on master, I know :) I just thought the "hud-" prefix was required in the code, as it is in other areas.

If entity name consistency is about to be dropped for those strings in the future, and the code is not relying on a specific prefix, I totally agree we shouldn't update the entity name. So, I will fix the data-l10n-id and use jank-threshold instead.
Thanks for spotting the typo ;)
Comment on attachment 8384040 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16756

R=me but please fix the typo. Thanks Théo!
Attachment #8384040 - Flags: review?(kaze) → review+
Thank you both!
As said in c#3, I reverted hud-jank-threshold back to jank-threshold and fixed the data-l10n-id instead, to keep existing translation. And fixed the typo.
Keywords: checkin-needed
Master: 2f72fbc4dd068bb6cce8d63b02c852fa19cb38d2
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S3 (14mar)
You need to log in before you can comment on or make changes to this bug.