Closed Bug 978414 Opened 6 years ago Closed 6 years ago

GLContext virtuals should all be MOZ_OVERRIDE in children, and const when possible

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

Attachments

(2 files)

C++ is really lax about this, but we should really be sure that virtual overrides are obvious, and don't just look like non-virtual funcs in child classes.
Attached patch patchSplinter Review
Attachment #8384076 - Flags: review?(bjacob)
Comment on attachment 8384076 [details] [diff] [review]
patch

Review of attachment 8384076 [details] [diff] [review]:
-----------------------------------------------------------------

I like that!

::: gfx/gl/GLContext.h
@@ +2543,5 @@
>       * changed; glViewport should be called as appropriate.
>       *
>       * Only valid if IsOffscreen() returns true.
>       */
> +    bool ResizeOffscreen(const gfx::IntSize& size) {

I see, virtualness wasn't used there.
Attachment #8384076 - Flags: review?(bjacob) → review+
Trivial bustage fix pushed directly to inbound in:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f483d8507eea
Attachment #8385092 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/17ee50aca7e5
https://hg.mozilla.org/mozilla-central/rev/f483d8507eea
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.