Closed Bug 978443 Opened 6 years ago Closed 6 years ago

Rename NS_STYLE_CLEAR_LEFT_AND_RIGHT to NS_STYLE_CLEAR_BOTH

Categories

(Core :: Layout, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: mats, Assigned: mats)

Details

Attachments

(2 files)

No description provided.
Attachment #8384123 - Flags: review?(dholbert)
I'm assuming we called this LEFT_AND_RIGHT in the old days because we had so many other NS_STYLE_CLEAR_* values (so "BOTH" would have been ambiguous).

Based on that assumption -- since we've removed almost all of the other values, in...
 http://hg.mozilla.org/mozilla-central/diff/14929e61959d/layout/base/nsStyleConsts.h
... I agree that renaming to BOTH now seems reasonable.
Comment on attachment 8384123 [details] [diff] [review]
part 1, scripted changes

r=me
Attachment #8384123 - Flags: review?(dholbert) → review+
Comment on attachment 8384124 [details] [diff] [review]
part 2, Fix whitespace and remove unnecessary parens in a few places and enumerate the possible break types in an assertion so that it doesn't make assumptions on the actual property values.

># HG changeset patch
># Parent 18d58b4e086bbff4ea2274dd77448915b195670f
># User Mats Palmgren <matspal@gmail.com>
>Bug 978443 - Fix whitespace and remove unnecessary parens in a few places and enumerate the possible break types in an assertion so that it doesn't make assumptions on the actual property values.  r=dholbert

Nit: I prefer having "part 1" / "part 2" in the actual commit message, for multi-patch bugs.  Without that, if someone just looks at this cset, then it looks like the main thrust of this bug is to "Fix whitespace and remove unnecessary parens in a few places and enumerate [etc]", which is the wrong impression and seems a bit all-over-the-place.

If it's labeled as "part 2", then it's clearer that this cset is *really* in the service of a more coherent overall goal. :)

r=me regardless though.
Attachment #8384124 - Flags: review?(dholbert) → review+
I folded the patches, the split here was only for reviewing purposes.
https://hg.mozilla.org/integration/mozilla-inbound/rev/34087559e75d
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/34087559e75d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.