978447 - Australis - Bookmarks widget submenu menu item doesn't have an active state

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Tim Nguyen :ntim]

STR :
- Open bookmarks panel
- mousedown on the bookmarks toolbar item

You'll see that there is no active state.
According to the spec, the active state is the same as the hover state for submenu items.

Comment 1

[:Gijs (he/him)]

On at least OS X the hover style is also missing on checked menu items.

Comment 2

[:Gijs (he/him)]

Attachment: fix Australis' bookmarks menu hover and active style some more,

Ugh.

Comment 3

[:Gijs (he/him)]

Attachment: fix Australis' bookmarks menu hover and active style some more,

Actually, it's just this, because otherwise the hover style overrides the checked style, so perhaps I should just land this...

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8386062 [details] [diff] [review]
fix Australis' bookmarks menu hover and active style some more,

Review of attachment 8386062 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review from Mike, even though I'm totes not a reviewer.  ;)

rs=me.

Comment 5

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/f8b675240214

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f8b675240214

Comment 7

[:Gijs (he/him)]

Comment on attachment 8386062 [details] [diff] [review]
fix Australis' bookmarks menu hover and active style some more,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 944079
User impact if declined: busted CSS
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): none
String or IDL/UUID changes made by this patch: none

Comment 8

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/985a5918e5b2