Closed Bug 978472 Opened 6 years ago Closed 6 years ago

Add support for leak checking in GenericRefCounted classes

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Assignee: nobody → ehsan
Depends on: 935778
Comment on attachment 8384165 [details] [diff] [review]
Add support for leak checking in GenericRefCounted classes

https://tbpl.mozilla.org/?tree=Try&rev=b610d1a88186
Attachment #8384165 - Flags: review?(bjacob)
Comment on attachment 8384165 [details] [diff] [review]
Add support for leak checking in GenericRefCounted classes

Review of attachment 8384165 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/GenericRefCounted.h
@@ +37,5 @@
>      // mechanism, it is welcome to do so by overriding AddRef() and Release().
>      void ref() { AddRef(); }
>      void deref() { Release(); }
> +
> +#if defined(MOZILLA_INTERNAL_API) && (defined(DEBUG) || defined(FORCE_BUILD_REFCNT_LOGGING))

Don't repeat such nontrivial boolean expressions on multiple lines, or else someone will update some of these and forget to update others.
Attachment #8384165 - Flags: review?(bjacob) → review-
Attachment #8384165 - Attachment is obsolete: true
Attachment #8385073 - Flags: review?(bjacob)
Attachment #8385073 - Flags: review?(bjacob) → review+
Attachment #8385073 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/9cfebec86c16
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Depends on: 985878
No longer depends on: 985878
Depends on: 987667
You need to log in before you can comment on or make changes to this bug.