978476 - webbrowser.js uses wrong progress listener

Status: RESOLVED INVALID

(DevTools :: General, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This code is where the devtools listen for progress listener updates:
  http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/webbrowser.js#1047

It uses addProgressListener from tabbrowser.xml. That means that it will get updates for whatever tab happens to be selected. I'm pretty certain that it actually wants to get updates for the tab being debugged. You can see the bad behavior with this STR:

1. Make a web page that goes to a different URL after a timeout.
2. Load that page and open the debugger.
3. Switch to a different tab and wait until the timeout fires.
4. Go back to the original tab. The debugger will still show scripts related to the original URL.

I think you probably want _tabActor.webProgress.addProgressListener.

Comment 1

[Mihai Sucan [:msucan]]

Bill, this is going to be fixed by one of your patches in bug 937172, if I am not mistaken - attachment 8385071 [details] [diff] [review].

(thanks for the patches and bug report)

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

A lot happened since the bug report, this should be fixed by now.