Closed Bug 978479 Opened 6 years ago Closed 6 years ago

remove flipped quad texture from mQuadVBO

Categories

(Core :: Graphics: Layers, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: gal, Assigned: gal)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 4 obsolete files)

We can flip drawing with a texture transform instead. This removes the need to move the tex coord attrib pointer around (a follow-up patch will enable mQuadVBO by default and only temporarily set to a custom VBO for more complex geometries).
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → gal
Attachment #8384171 - Flags: review?(bjacob)
Blocks: 978515
Comment on attachment 8384171 [details] [diff] [review]
patch

Review of attachment 8384171 [details] [diff] [review]:
-----------------------------------------------------------------

Less state carried around, is better.

::: gfx/layers/opengl/CompositorOGL.h
@@ +211,5 @@
>  #endif
>  
> +  /**
> +   * VBO that has some basics in it for a textured quad,
> +   * including vertex coords and texcoords for both.

Did you mean to remove "for both" here?
Attachment #8384171 - Flags: review?(bjacob) → review+
I think the "for both" is still accurate no?
What does "for both" refer to in the sentence, "VBO that has some basics in it for a textured quad, including vertex coords and texcoords for both." ?

It used to refer to "for both flipped and non-flipped" but that part is gone now.
Ok will remove it.
Attached patch patch, carrying r=bjacob (obsolete) — Splinter Review
Attachment #8384171 - Attachment is obsolete: true
Attachment #8386838 - Flags: review+
Keywords: checkin-needed
Sorry about that. Will check.
Attached patch patch (obsolete) — Splinter Review
Attachment #8386838 - Attachment is obsolete: true
Attached patch patch (obsolete) — Splinter Review
Attachment #8387190 - Attachment is obsolete: true
Attachment #8387198 - Flags: review?(bjacob)
Comment on attachment 8387198 [details] [diff] [review]
patch

Review of attachment 8387198 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/CompositorOGL.cpp
@@ +1487,5 @@
>    }
>  }
>  
>  void
>  CompositorOGL::BindAndDrawQuad(ShaderProgramOGL *aProg,

yay for killing boolean function parameters.
Attachment #8387198 - Flags: review?(bjacob) → review+
Keywords: checkin-needed
Blocks: 980364
https://hg.mozilla.org/mozilla-central/rev/fed5c6d9c1da
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Backed out:

https://hg.mozilla.org/integration/mozilla-inbound/rev/a63f5694f562

Reason: is one of two patches in the regression range for bug 990233, 5% tresize regression on OSX 10.6. See conversation on bug 990233.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Please re-land this separately.
Keywords: checkin-needed
Attachment #8387198 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/bf5b4bd387b3
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.