978479 - remove flipped quad texture from mQuadVBO

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Andreas Gal :gal]

We can flip drawing with a texture transform instead. This removes the need to move the tex coord attrib pointer around (a follow-up patch will enable mQuadVBO by default and only temporarily set to a custom VBO for more complex geometries).

Comment 1

[Andreas Gal :gal]

Attachment: patch

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 8384171 [details] [diff] [review]
patch

Review of attachment 8384171 [details] [diff] [review]:
-----------------------------------------------------------------

Less state carried around, is better.

::: gfx/layers/opengl/CompositorOGL.h
@@ +211,5 @@
>  #endif
>  
> +  /**
> +   * VBO that has some basics in it for a textured quad,
> +   * including vertex coords and texcoords for both.

Did you mean to remove "for both" here?

Comment 3

[Andreas Gal :gal]

I think the "for both" is still accurate no?

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

What does "for both" refer to in the sentence, "VBO that has some basics in it for a textured quad, including vertex coords and texcoords for both." ?

It used to refer to "for both flipped and non-flipped" but that part is gone now.

Comment 5

[Andreas Gal :gal]

Ok will remove it.

Comment 6

[Andreas Gal :gal]

Attachment: patch, carrying r=bjacob

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96f2905b175d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out for OSX reftest failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/969220ac8459

https://tbpl.mozilla.org/php/getParsedLog.php?id=35736925&tree=Mozilla-Inbound

Comment 9

[Andreas Gal :gal]

Sorry about that. Will check.

Comment 10

[Andreas Gal :gal]

Attachment: patch

Comment 11

[Andreas Gal :gal]

Attachment: patch

Comment 12

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 8387198 [details] [diff] [review]
patch

Review of attachment 8387198 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/CompositorOGL.cpp
@@ +1487,5 @@
>    }
>  }
>  
>  void
>  CompositorOGL::BindAndDrawQuad(ShaderProgramOGL *aProg,

yay for killing boolean function parameters.

Comment 13

[Andreas Gal :gal]

https://tbpl.mozilla.org/?tree=Try&rev=9fb3d30fdf7a

Comment 14

[Andreas Gal :gal]

Attachment: patch for check-in

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fed5c6d9c1da

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fed5c6d9c1da

Comment 17

[Benoit Jacob [:bjacob] (mostly away)]

Backed out:

https://hg.mozilla.org/integration/mozilla-inbound/rev/a63f5694f562

Reason: is one of two patches in the regression range for bug 990233, 5% tresize regression on OSX 10.6. See conversation on bug 990233.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/a63f5694f562

Comment 19

[Andreas Gal :gal]

Please re-land this separately.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf5b4bd387b3

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bf5b4bd387b3