Closed Bug 978557 Opened 10 years ago Closed 7 years ago

Switch to a custom CSS tokenizer which is faster and interatable

Categories

(DevTools :: Source Editor, defect)

Product:
DevTools
Component:
Source Editor
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: Optimizer, Unassigned)

References

Details

The css tokenizer present in browser/devtools/sourceeditor/css-tokenizer.js is good, but it is limited and is slow. In my debugging, tokenizing is almost 85% of the overall autocompletion step.

We can improve the tokenizer.

Also, while at it, we will also add yielding of tokens so that you can go backward and forward from a location and spiting out tokens for them.
Related to bug 1152033, but not identical -- that bug exposes the built-in tokenizer,
but there's no way to lex in the reverse direction.
Depends on: 1152033
That tokenizer is gone now; and there's another bug open about style editor autocomplete performance.
So, I'm closing this one.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.