978622 - COVERAGE=1 does not work when requireApp is not immediately invoked

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Description

[Kevin Grandon :kgrandon]

Take the following pattern, which is very common in gaia, COVERAGE=1 does not display results for some of the files.

// Test file start
// This file works in coverage
requireApp('app/js/some_file.js');

suite('my suite', function() {
  setup(function(done) {
    // This file is *not* included in coverage results.
    requireApp('app/js/some_other_file.js');
  });
});

Comment 1

[Kevin Grandon :kgrandon]

Ricky - any interest in picking this up? If not - could you point to some source files of where one would look to fix this? Thanks!

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Yo, I'm working on it recently. 

Most of the coverage tool doesn't support lazy loading on browser side. Blanket.js cannot cover if we load files in this way.

I'm going to patch blanket.js. It will be a new feature and hope they can accept the patch. :)

Comment 3

[Kevin Grandon :kgrandon]

Reopening this because I'm still seeing this on master. When I run the command: COVERAGE=1 make test-agent-test APP=search

I only see the following results:

File Name - Covered/Total Smts - Coverage (%)

  http://search.gaiamobile.org:8080/js/eme/eme.js - 11/25 - 44 %
  http://search.gaiamobile.org:8080/js/providers/provider.js - 35/36 - 97.22 %
  http://search.gaiamobile.org:8080/js/providers/bgimage.js - 16/27 - 59.26 %

In reality, many more files are included in requireApp(), but only asynchronously in the setup. Ricky - any guess here? Can you show me the outpost when you run this command? Thanks!

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Oops! It really works on my mac / ubuntu regardless testing on Test Agent App or command line.
Did you try this feature by enabling in Test Agent App?

Comment 5

[Ricky Chien [:rickychien] (inactive)]

I just found a weird situation that I carelessly use "make update-common" in gaia and it replaced my chai.js so that caused an incorrect result.

Or another cause might be somethings different in directories which were ignored by git such as node_modules.
So we can try to update node_modules :)

Comment 6

[Kevin Grandon :kgrandon]

Thanks for checking Ricky! I will be in Taipei next week, so perhaps we can sit together for a bit and debug this.

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Wow! so cool!

I'll go to office in Wed, Thu and Fri (My internship time), so we can discuss this problem at that time.

And I'm still improving my poor English now, so hope you can accept my speaking :)

Comment 8

[Julien Wajsberg [:julienw]]

(In reply to Ricky Chien [:rickychien] from comment #5)
> I just found a weird situation that I carelessly use "make update-common" in
> gaia and it replaced my chai.js so that caused an incorrect result.

Shouldn't this be fixed in some way?

Comment 9

[Kevin Grandon :kgrandon]

Apparently this is invalid. Re-cloning gaia seems to have fixed this for me (but not running this after a make really-clean). No idea why, but we should be good for now. Thanks and sorry for the confusion here.