978632 - Prevent a click to fire when the home button is pressed on some devices

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Same story as bug 941950. Seems like there is a mousedown/mouseup as well.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug978632.patch

I've heard a few number of people complaining that the keyboard close when they hit the space key. I wonder if this patch is going to help if those devices fires mouse events too and the touch is a it on the screen below the space bar.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8384358 [details] [diff] [review]
bug978632.patch

Review of attachment 8384358 [details] [diff] [review]:
-----------------------------------------------------------------

The 3rd time I saw this patch!

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/11767ff7a8c2b1394152a5808db0eca103e1ff23

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug978632.tests.patch

Etienne can you give me a stamp so I unbreak the tree (it was green on Travis but it should be a non-required tests).

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 8384593 [details] [diff] [review]
bug978632.tests.patch

Review of attachment 8384593 [details] [diff] [review]:
-----------------------------------------------------------------

stamp

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

landed: https://github.com/mozilla-b2g/gaia/commit/a6d69e2e3f36c29d54ea5e331eeedeb7ea92a37f

thanks for the quick stamp.