978635 - 'now' is interpreted as midnight for searches

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Simon Green]

Starting with bug 737436, a custom search with the change value of 'now' is interpreted as been at midnight this morning, as opposed to now, which is what most people would expect.

For example, if I do a custom search on 'Assignee' 'changed before' 'now' (the string now)

the resulting SQL is (taken from brc):

LEFT JOIN bugs_activity AS act_41_3 ON bugs.bug_id = act_41_3.bug_id AND act_41_3.fieldid = 41 AND act_41_3.bug_when <= '2014-03-03 00:00:00'

Surely 'now' should mean now, and not midnight for non-deadline values. Of course the danger in changing it in a release is that it might break queries which assume 'now' means midnight.

Comment 1

[Frédéric Buclin]

This is not a regression and this has nothing to do with bug 737436. "Now" is supported in boolean charts since Bugzilla 3.6 only, and the date has always been truncated, i.e. the time part of the day has always been ignored.

Comment 3

[Fedor Ezeev]

Attachment: 1108405_2.diff

Suggested patch (copyed from Bug 1108405)

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 8533023 [details] [diff] [review]
1108405_2.diff

Review of attachment 8533023 [details] [diff] [review]:
-----------------------------------------------------------------

r=gerv. "now" means now.

Gerv

::: Bugzilla/Search.pm
@@ +2214,5 @@
> +    if (lc($str) eq 'now') {
> +        my ($sec, $min, $hour, $mday, $month, $year, $wday) = localtime(time());
> +        return sprintf("%4d-%02d-%02d %02d:%02d:%02d", $year+1900, $month+1, $mday, $hour, $min, $sec);
> +    }
> +	

Remove trailing whitespace on this line.

Comment 5

[Fedor Ezeev]

Attachment: 978635.diff

previous patch without trailing space

Comment 6

[Frédéric Buclin]

(In reply to Gervase Markham [:gerv] from comment #4)
> r=gerv. "now" means now.

Before approving this patch, did you read and investigate my question in bug 1108405 comment 2?

Comment 7

[Gervase Markham [:gerv]]

LpSolit: I'm not sure what you mean. The question in bug 1108405 comment 2 refers to bug 217029 comment 5 which is a patch adding a particular behaviour for "". The patch on this bug does not change the behaviour for "".

If you have a concern, it would help if you stated it plainly; following it back through several bugs and trying to work out what you mean is prone to error. :-)

Gerv

Comment 8

[Simon Green]

I agree with gerv. But then I wrote this bug. 'now' should means now. It should be relnoted though in case people are currently using 'now' to mean midnight (server time).

  -- simon

Comment 9

[Fedor Ezeev]

I have no write access to git, so I need someone's help, who will push my patch to repo.

Comment 10

[Simon Green]

(In reply to Fedor Ezeev from comment #9)
> I have no write access to git, so I need someone's help, who will push my
> patch to repo.

It will be the reviewer who will commit the patch for you. In this case that would be gerv.

Comment 11

[Gervase Markham [:gerv]]

To ssh://[e-mail]/bugzilla/bugzilla.git
   8ab6357..f264250  master -> master

Thanks for the patch, Fedor!

Gerv