Closed Bug 978636 Opened 7 years ago Closed 7 years ago

detect MSYS2 on configure

Categories

(NSPR :: NSPR, defect, P2)

Product:
NSPR
Component:
NSPR
Platform:
x86
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
4.10.5

People

(Reporter: m_kato, Assigned: m_kato)

References

(
URL
)

Details

Attachments

(1 file, 2 obsolete files)

Support msys2, v2
3.62 KB, patch
wtc
: checked-in+
Details | Diff | Splinter Review 
uname is changed from msys, so we need this target type for it.

$ uname -a (on x64)
MSYS_NT-6.3 mypc-dell 2.0.0(0.271/5/3) 2014-01-23 12:08 x86_64 Msys
Makoto: Thanks for the bug report. What do we need to do to detect
the uname output of MSYS2?
(In reply to Wan-Teh Chang from comment #1)
> Makoto: Thanks for the bug report. What do we need to do to detect
> the uname output of MSYS2?

If not cross compiling,  configure uses the following code to set OS_* values.

    OS_ARCH=`uname -s | sed -e 's|/|_|g'`
    OS_RELEASE=`uname -r`
    OS_TEST=`uname -m`
Attached patch fix (obsolete) — — Splinter Review 
When using msys shell, the latest config.guess detects as x86_64-pc-msys.
Attachment #8387373 - Flags: review?(wtc)
Comment on attachment 8387373 [details] [diff] [review]
fix

oops, this has error
Attachment #8387373 - Flags: review?(wtc)
Attached patch Support msys2 (obsolete) — — Splinter Review
Attachment #8387373 - Attachment is obsolete: true
Attachment #8387374 - Flags: review?(wtc)
Assignee: wtc → m_kato
Status: NEW → ASSIGNED
Priority: P5 → P2
Target Milestone: --- → 4.10.5
Comment on attachment 8387374 [details] [diff] [review]
Support msys2

Review of attachment 8387374 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc. Thanks for the patch.

Nit: it would be nice to consistently list *-msys* right after *-mingw*.
I can take care of this when I check in this patch.

Does this require updating NSPR's config.guess script? I will do that in
bug 695993.
Attachment #8387374 - Flags: review?(wtc) → review+
(In reply to Wan-Teh Chang from comment #6)
> Comment on attachment 8387374 [details] [diff] [review]
> Support msys2
> 
> Review of attachment 8387374 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=wtc. Thanks for the patch.
> 
> Nit: it would be nice to consistently list *-msys* right after *-mingw*.
> I can take care of this when I check in this patch.

Thanks.
 
> Does this require updating NSPR's config.guess script? I will do that in
> bug 695993.

It isn't required.  If using MSYS2, we can use --target and --host like Win64.
Patch checked in: https://hg.mozilla.org/projects/nspr/rev/efe50c09c1cd
Attachment #8387374 - Attachment is obsolete: true
Attachment #8388991 - Flags: checked-in+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.