Closed
Bug 978636
Opened 7 years ago
Closed 7 years ago
detect MSYS2 on configure
Categories
(NSPR :: NSPR, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
4.10.5
People
(Reporter: m_kato, Assigned: m_kato)
References
()
Details
Attachments
(1 file, 2 obsolete files)
3.62 KB,
patch
|
wtc
:
checked-in+
|
Details | Diff | Splinter Review |
uname is changed from msys, so we need this target type for it. $ uname -a (on x64) MSYS_NT-6.3 mypc-dell 2.0.0(0.271/5/3) 2014-01-23 12:08 x86_64 Msys
Comment 1•7 years ago
|
||
Makoto: Thanks for the bug report. What do we need to do to detect the uname output of MSYS2?
Assignee | ||
Comment 2•7 years ago
|
||
(In reply to Wan-Teh Chang from comment #1) > Makoto: Thanks for the bug report. What do we need to do to detect > the uname output of MSYS2? If not cross compiling, configure uses the following code to set OS_* values. OS_ARCH=`uname -s | sed -e 's|/|_|g'` OS_RELEASE=`uname -r` OS_TEST=`uname -m`
Assignee | ||
Comment 3•7 years ago
|
||
When using msys shell, the latest config.guess detects as x86_64-pc-msys.
Attachment #8387373 -
Flags: review?(wtc)
Assignee | ||
Comment 4•7 years ago
|
||
Comment on attachment 8387373 [details] [diff] [review] fix oops, this has error
Attachment #8387373 -
Flags: review?(wtc)
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8387373 -
Attachment is obsolete: true
Attachment #8387374 -
Flags: review?(wtc)
Updated•7 years ago
|
Assignee: wtc → m_kato
Status: NEW → ASSIGNED
Priority: P5 → P2
Target Milestone: --- → 4.10.5
Comment 6•7 years ago
|
||
Comment on attachment 8387374 [details] [diff] [review] Support msys2 Review of attachment 8387374 [details] [diff] [review]: ----------------------------------------------------------------- r=wtc. Thanks for the patch. Nit: it would be nice to consistently list *-msys* right after *-mingw*. I can take care of this when I check in this patch. Does this require updating NSPR's config.guess script? I will do that in bug 695993.
Attachment #8387374 -
Flags: review?(wtc) → review+
Assignee | ||
Comment 7•7 years ago
|
||
(In reply to Wan-Teh Chang from comment #6) > Comment on attachment 8387374 [details] [diff] [review] > Support msys2 > > Review of attachment 8387374 [details] [diff] [review]: > ----------------------------------------------------------------- > > r=wtc. Thanks for the patch. > > Nit: it would be nice to consistently list *-msys* right after *-mingw*. > I can take care of this when I check in this patch. Thanks. > Does this require updating NSPR's config.guess script? I will do that in > bug 695993. It isn't required. If using MSYS2, we can use --target and --host like Win64.
Comment 8•7 years ago
|
||
Patch checked in: https://hg.mozilla.org/projects/nspr/rev/efe50c09c1cd
Attachment #8387374 -
Attachment is obsolete: true
Attachment #8388991 -
Flags: checked-in+
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•