Closed Bug 978689 Opened 10 years ago Closed 10 years ago

[Settings] Fix for() loop in carrier.js file.

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 unaffected)

RESOLVED FIXED
1.4 S3 (14mar)
blocking-b2g 1.3+
Tracking Status
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- unaffected

People

(Reporter: jaoo, Assigned: jaoo)

Details

Attachments

(2 files)

While working on bug 975918 we noticed an issue in a for loop. We fixed it in master branch but the work done in bug 975918 cannot be uplifted to fix the problem in v1.3 branch. This bugs is to fix the issue and we will provide a v1.3-only patch for it.
Assignee: nobody → josea.olivera
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #0)
> While working on bug 975918 we noticed an issue in a for loop. 

Sorry I meant bug 969298.

> We fixed it
> in master branch but the work done in bug 975918 cannot be uplifted to fix the problem in v1.3 branch.

Same here, I meant bug 969298.

> This bugs is to fix the issue and we will provide a v1.3-only patch for it.
Attached patch v1Splinter Review
Fabien, as you might remember last week we worked on bug 969298 and while reviewing its patch we found an issue in a for loop. As the whole patch from bug 969298 won't be uplifted we need to fix the for loop with a 1.3-only patch. Here is this patch. Could you take a look at it please? Thanks!
Attachment #8384545 - Flags: review?(kaze)
As this patch fix an issue happening on 1.3 branch, let's request 1.3+ flag.

Some background for the triage decision. The user impact might be the user seeing a APN selected in the APNs panels that is not the current one in use (used) by the RIL plumbing.
blocking-b2g: --- → 1.3?
Attachment #8384545 - Flags: review?(kaze) → review+
blocking-b2g: 1.3? → 1.3+
Target Milestone: --- → 1.4 S3 (14mar)
Comment on attachment 8384545 [details] [diff] [review]
v1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):

Bug 962453

[User impact] if declined:

The user impact might be the user seeing a APN selected in the APNs panels that is not the current one in use (used) by the RIL plumbing.

[Testing completed]:

Yes, nothing is broken.

[Risk to taking this patch] (and alternatives if risky):

Low

[String changes made]:

None
Attachment #8384545 - Flags: approval-gaia-v1.3?(fabrice)
Attachment #8384545 - Flags: approval-gaia-v1.3?(fabrice) → approval-gaia-v1.3+
Hi John,

Could you please help us with the uplift to v1.3 branch?. Many thanks!
Flags: needinfo?(jhford)
Flags: needinfo?(jhford) → needinfo?(ryanvm)
v1.3: f385eb84179c0e338475bace10ce0f1e2d0f76d6

FYI, in the future, we only look for fixed bugs needing uplift on a regular basis. In cases like these, a checkin-needed goes a long way :)
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(ryanvm)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: