Closed
Bug 978689
Opened 10 years ago
Closed 10 years ago
[Settings] Fix for() loop in carrier.js file.
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 unaffected)
Tracking | Status | |
---|---|---|
b2g-v1.3 | --- | fixed |
b2g-v1.3T | --- | fixed |
b2g-v1.4 | --- | unaffected |
People
(Reporter: jaoo, Assigned: jaoo)
Details
Attachments
(2 files)
46 bytes,
text/x-github-pull-request
|
Details | Review | |
1.02 KB,
patch
|
kaze
:
review+
fabrice
:
approval-gaia-v1.3+
|
Details | Diff | Splinter Review |
While working on bug 975918 we noticed an issue in a for loop. We fixed it in master branch but the work done in bug 975918 cannot be uplifted to fix the problem in v1.3 branch. This bugs is to fix the issue and we will provide a v1.3-only patch for it.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → josea.olivera
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #0) > While working on bug 975918 we noticed an issue in a for loop. Sorry I meant bug 969298. > We fixed it > in master branch but the work done in bug 975918 cannot be uplifted to fix the problem in v1.3 branch. Same here, I meant bug 969298. > This bugs is to fix the issue and we will provide a v1.3-only patch for it.
Assignee | ||
Comment 3•10 years ago
|
||
Fabien, as you might remember last week we worked on bug 969298 and while reviewing its patch we found an issue in a for loop. As the whole patch from bug 969298 won't be uplifted we need to fix the for loop with a 1.3-only patch. Here is this patch. Could you take a look at it please? Thanks!
Assignee | ||
Updated•10 years ago
|
Attachment #8384545 -
Flags: review?(kaze)
Assignee | ||
Comment 4•10 years ago
|
||
As this patch fix an issue happening on 1.3 branch, let's request 1.3+ flag. Some background for the triage decision. The user impact might be the user seeing a APN selected in the APNs panels that is not the current one in use (used) by the RIL plumbing.
blocking-b2g: --- → 1.3?
Updated•10 years ago
|
status-b2g-v1.3:
--- → affected
Updated•10 years ago
|
Attachment #8384545 -
Flags: review?(kaze) → review+
Updated•10 years ago
|
blocking-b2g: 1.3? → 1.3+
Updated•10 years ago
|
Target Milestone: --- → 1.4 S3 (14mar)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8384545 [details] [diff] [review] v1 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Bug 962453 [User impact] if declined: The user impact might be the user seeing a APN selected in the APNs panels that is not the current one in use (used) by the RIL plumbing. [Testing completed]: Yes, nothing is broken. [Risk to taking this patch] (and alternatives if risky): Low [String changes made]: None
Attachment #8384545 -
Flags: approval-gaia-v1.3?(fabrice)
Updated•10 years ago
|
Attachment #8384545 -
Flags: approval-gaia-v1.3?(fabrice) → approval-gaia-v1.3+
Comment 6•10 years ago
|
||
Hi John, Could you please help us with the uplift to v1.3 branch?. Many thanks!
Flags: needinfo?(jhford)
Updated•10 years ago
|
Flags: needinfo?(jhford) → needinfo?(ryanvm)
Comment 7•10 years ago
|
||
v1.3: f385eb84179c0e338475bace10ce0f1e2d0f76d6 FYI, in the future, we only look for fixed bugs needing uplift on a regular basis. In cases like these, a checkin-needed goes a long way :)
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v1.4:
--- → unaffected
Flags: needinfo?(ryanvm)
Resolution: --- → FIXED
Updated•10 years ago
|
status-b2g-v1.3T:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•